Skip to content

Add streamlink config, and utilize yt-dlp in place of youtube-dl#12

Draft
mil1i wants to merge 4 commits intomicahmo:masterfrom
mil1i:streamlink-ytdlp
Draft

Add streamlink config, and utilize yt-dlp in place of youtube-dl#12
mil1i wants to merge 4 commits intomicahmo:masterfrom
mil1i:streamlink-ytdlp

Conversation

@mil1i
Copy link
Copy Markdown

@mil1i mil1i commented Jul 26, 2023

I can keep playing with this some. But right now, both streamlink and yt-dlp appear to be working for me without ads. I've only tested yt-dlp a little bit without ads, as it's late right now.

But effectively:

  • Add ~/.config/streamlink/config and ~/.config/streamlink/config.twitch which will bypass ads and set best default values for streaming twitch.
  • Utilize yt-dlp in place of youtube-dl
  • Adds known headers for yt-dlp to inform twitch that the client is an "ad free client".

So far, both seem to work initially. Skip pre-roll ads when starting a stream and starts very quick. The issue I currently see with both is that when twitch attempts to show a mid-roll ad the stream briefly freezes and so far requires "restarting" (or pressing play, from my client at least) to resume it.

I've been testing from Firefox browser + Apple TV (tvOS) Plex app. I tested from macOS Plex Desktop app as well, but it failed to play with any setting.

Unsure at the moment how to resolve the mid-roll ads breaking the stream. Need to dig more.

@mil1i mil1i force-pushed the streamlink-ytdlp branch from 6210b28 to cfe7505 Compare July 26, 2023 05:48
Copy link
Copy Markdown
Owner

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for working on this!

I have one overall comment which is that you're welcome to rip out any reference to youtube-dl. I am happy to make the switch completely to yt-dlp. No need to maintain references to both.

@micahmo
Copy link
Copy Markdown
Owner

micahmo commented Jul 26, 2023

Also try updating your branch with the latest master to fix the CI run.

@mil1i
Copy link
Copy Markdown
Author

mil1i commented Jul 26, 2023

I tested a bit more this morning. I must have gotten lucky last night as I got hit with a bunch of "ad"/"commercial" breaks today.

Running into it to freezing the stream a bunch and having to restart it. Which unfortunately makes it a pain to use. So I want to continue playing around. Probably shouldn't merge these especially if the freezing doesn't happen for you or anyone else.

I just wanted to use this to drop Turbo subscription, and still be able to watch Twitch without getting hit by ad breaks every 10 minutes.

@mil1i mil1i force-pushed the streamlink-ytdlp branch from cfe7505 to f7b1a07 Compare July 26, 2023 13:57
@micahmo
Copy link
Copy Markdown
Owner

micahmo commented Jul 26, 2023

I want to continue playing around. Probably shouldn't merge these especially if the freezing doesn't happen for you or anyone else.

Sure, no problem! Feel free to play around and see if it gets into a state you'd be comfortable merging. If not, you're of course welcome to keep using your branch, and we can keep it here for reference. Thanks for taking the time to work on this!

@mil1i mil1i force-pushed the streamlink-ytdlp branch from c8f3257 to 52a76ac Compare July 26, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants