Allow organizers to manage participants and track payments after event ends

[michaelchu]

Summary

• Organizers can add/remove participants on past events (claim empty slots, remove participants, use the join button) — non-organizers still see "Registration Closed"
• Past paid events with outstanding payments stay in the Organizing tab (and group Active filter) instead of moving to Archive, so organizers can track who still owes
• Events are only fully archived once all participants have paid (or the event isn't a paid event)

Test plan

• Unit tests for organizer controls on past events (claim buttons, join button, remove button)
• Unit tests for non-organizer still seeing "Registration Closed" on past events
• Unit tests for past paid events with unpaid participants staying active
• Unit tests for past paid events with all paid participants being archived
• Manual: as organizer, view a past paid event with unpaid participants → confirm it appears in Organizing tab, not Archive
• Manual: mark all participants as paid → confirm event moves to Archive
• Manual: check group detail page shows same behavior in Active/Archived filter

🤖 Generated with Claude Code

[michaelchu]

Code review

Found 1 issue:

1. Non-organizers can join/withdraw from past paid events with unsettled payments. The join button uses isArchived as the sole guard, but isArchived is false for past paid events with pending payments. This means any user (not just the organizer) sees an active join/withdraw button on a past event that still has unsettled payments. The "Anyone can register for public events" RLS policy would allow the insert to succeed. Previously this used isEventCompleted() && !isOrganizer which correctly blocked non-organizers. The fix would be to use (isArchived || (isEventPast && !isOrganizer)) for the button disabled/onClick/label guards.

roster/src/pages/EventDetailPage.tsx

Lines 1016 to 1038 in 0d291c1

	onClick={() => {
	if (isArchived) return;
	if (isEventFull && !userRegistration) return;
	if (showRegistrationForm) {
	openSignupDrawer();
	} else if (userRegistration) {
	setShowWithdrawDialog(true);
	} else {
	handleDirectJoin();
	}
	}}
	disabled={isArchived || submitting || (isEventFull && !userRegistration)}
	className={`w-full text-white shadow-lg drop-shadow-md ${
	isArchived || (isEventFull && !userRegistration)
	? 'bg-muted-foreground'
	: userRegistration && !showRegistrationForm
	? 'bg-destructive hover:bg-destructive/90'
	: 'bg-gradient-to-r from-purple-500 to-pink-500 hover:from-purple-600 hover:to-pink-600'
	}`}
	size="default"
	>
	{isArchived ? (
	<>

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[Copilot]

Pull request overview

This PR allows event organizers to manage participants (add/remove) on past events, and keeps past paid events with outstanding payments visible in the Organizing tab (and group Active filter) rather than immediately archiving them. Events are only moved to the archive once all participants have settled their payments.

Changes:

• EventDetailPage.tsx: Introduces separate isEventPast and isArchived flags. A past paid event is only "archived" when all participants have paid; until then, organizers retain full participant management controls.
• EventsPage.tsx: loadOrganizingEventsCallback now keeps unsettled past paid events in the Organizing tab; loadArchivedEventsCallback now excludes unsettled paid events from the Archive tab.
• GroupDetailPage.tsx: Adds an _unsettled marker to past paid group events with outstanding payments, keeping them in the "Active" filter and out of "Archived."
• New test files: EventsPage.test.tsx and GroupDetailPage.test.tsx cover the new filtering behavior; EventDetailPage.test.tsx receives an additional describe block covering organizer/non-organizer controls on past events.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/pages/EventDetailPage.tsx	Replaces monolithic isArchived (based only on time) with a richer condition that requires payment settlement for paid events
src/pages/EventsPage.tsx	Filters organizing/archived event lists using payment summaries so unsettled events stay in Organizing
src/pages/GroupDetailPage.tsx	Marks past paid group events as _unsettled and adjusts Active/Archived filtering accordingly
src/pages/__tests__/EventDetailPage.test.tsx	Adds test cases for organizer/non-organizer behavior on past events
src/pages/__tests__/EventsPage.test.tsx	New test file for organizing/archive tab placement based on payment status
src/pages/__tests__/GroupDetailPage.test.tsx	New test file for Active/Archived group event filtering based on payment status

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.