Add local release date for movie#800
Open
ArthurTakase wants to merge 1 commit intomichaldrabik:masterfrom
Open
Add local release date for movie#800ArthurTakase wants to merge 1 commit intomichaldrabik:masterfrom
ArthurTakase wants to merge 1 commit intomichaldrabik:masterfrom
Conversation
Owner
|
Thanks will be looking but I have few other things to finish first. However - for any translation related issues are changes please use CrowdIn https://crowdin.com/project/showly-android-app :) |
ArthurTakase
force-pushed
the
feat/localRelease
branch
from
4626bf6 to
5a58477
Compare
ArthurTakase
force-pushed
the
feat/localRelease
branch
from
5a58477 to
30d756a
Compare
ArthurTakase
force-pushed
the
feat/localRelease
branch
2 times, most recently
from
d67f726 to
98c000e
Compare
ArthurTakase
force-pushed
the
feat/localRelease
branch
from
98c000e to
12676cf
Compare
ArthurTakase
force-pushed
the
feat/localRelease
branch
from
12676cf to
cc3e286
Compare
Select release date region in app settings. Add region flag next to local release date in movie details. If the local date is identical to the original release, both flags are displayed. If the local date is different, both dates are displayed, each with its flag. If no local date exists, this does not change the current app. Update release date when region change. handle when no date use TMDB for more accurate dates poster from selected region FIX: merge
ArthurTakase
force-pushed
the
feat/localRelease
branch
from
cc3e286 to
0d09ebb
Compare
Contributor
Author
|
Hello @michaldrabik, I hope you're doing well. Are there any changes I can make to this PR to ensure the feature can be made available in the application? Thank you in advance for your feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I'm redoing the PR after cleaning my fork)
Select release date region in app settings (same setting as network region).
Update release date when region change.
Add region flag next to local release date in movie details.
Modification of "findBestImage" to give priority to posters from the user's region (movies and series).
Added a flag to indicate the origin country of shows.