Skip to content

Budget app features#1

Open
micheaol wants to merge 28 commits intodevfrom
budget-app-features
Open

Budget app features#1
micheaol wants to merge 28 commits intodevfrom
budget-app-features

Conversation

@micheaol
Copy link
Copy Markdown
Owner

@micheaol micheaol commented Mar 16, 2022

In this PR:

  • I create a splash screen

  • Sign up and login pages

    • The user can register in the app with full name, email, and password (all mandatory).

    • The user can log into the app using email and password.

  • Home page (categories page)

    • When the user logs in, they are presented with the categories page.
    • For each category, the user can see their name, icon, and the total amount of all the transactions that belong to that category.
    • When the user clicks (or taps) on a category item, the application navigates to the transactions page for that category.
    • There is a button "add a new category" at the bottom that brings the user to the page to create a new category.
  • Transactions page

    • For a given category, the list of transactions is presented.
    • At the top of the page, the user could see the total amount for the category (sum of all of the amounts of the transactions in that category).
    • There is a button "add a new transaction" at the bottom that brings the user to the page to create a new transaction.
    • When the user clicks on the "Back" button (<), the user navigates to the home page.
  • "Add a new category" page

    • The user fills out a form to create a new category, indicating their name and icon (both mandatory).
    • The user clicks (or taps) the "Save" button to create the new category, and is taken to the home page on success.
    • When the user clicks on the "Back" button (<), the user navigates to the home page.
  • "Add a new transaction" page

    • The user fills out a form to create a new transaction with:
      • name (mandatory)
      • amount (mandatory)
      • categories (mandatory at least one)
  • Video Presentation is HERE

Copy link
Copy Markdown

@Emmyn5600 Emmyn5600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @micheaol

Good job so far! I know you have worked hard on making this milestone But There are some issues that you still need to work on to go to the next project but you are almost there!

To highlight 🍾

  • All linters are passing ✔️
  • Good commit history ✔️
  • Good PR description ✔️
  • The database is well structured/created. ✔️
  • You have implemented almost all the requirements. ✔️

Required Changes ♻️

  • Check the comment under the review

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!:clap::clap::clap:

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@micheaol micheaol temporarily deployed to check-budget-app March 17, 2022 09:30 Inactive
@micheaol micheaol temporarily deployed to check-budget-app March 17, 2022 09:41 Inactive
@arslanbisharat
Copy link
Copy Markdown

Approved 👏

Hi there,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

To Highlight:

  • The Pull Request has a proper title and description. ✔️
  • You have added a descriptive Readme file. Good Job. ✔️
  • There is no linter error is present. ✔️
  • Project has met all the technical aspects you needed for this project. Keep rocking! ✔️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of code reviews per project which you can see from your dashboard. If you think that the code review was not fair, you can request a second opinion using this form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants