Skip to content

Cast attr to string to prevent a PHP deprecation warning in 8.1 #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025
Merged

Cast attr to string to prevent a PHP deprecation warning in 8.1 #365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1686c3
Cast attr to string to prevent a PHP deprecation warning in 8.1
beryllium Dec 3, 2021
6b1fcad
Update the call to preg_match_all to coalesce an empty string on $attr
beryllium Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Michelf/MarkdownExtra.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @package php-markdown
* @author Michel Fortin <michel.fortin@michelf.com>
* @copyright 2004-2019 Michel Fortin <https://michelf.com/projects/php-markdown/>
* @copyright (Original Markdown) 2004-2006 John Gruber <https://daringfireball.net/projects/markdown/>

Check failure on line 8 in Michelf/MarkdownExtra.php

View workflow job for this annotation

GitHub Actions / Linting - PHP 8.1 

PHPDoc tag @copyright has invalid value ((Original Markdown) 2004-2006 John Gruber <https://daringfireball.net/projects/markdown/>): Unexpected token "Markdown", expected ')' at offset 264 on line 7
*/

namespace Michelf;
Expand Down Expand Up @@ -229,7 +229,7 @@
}

// Split on components
preg_match_all('/[#.a-z][-_:a-zA-Z0-9=]+/', $attr, $matches);
preg_match_all('/[#.a-z][-_:a-zA-Z0-9=]+/', $attr ?? '', $matches);

Check failure on line 232 in Michelf/MarkdownExtra.php

View workflow job for this annotation

GitHub Actions / Linting - PHP 8.1 

Variable $attr on left side of ?? always exists and is not nullable.
$elements = $matches[0];

// Handle classes and IDs (only first ID taken into account)
Expand Down Expand Up @@ -1796,7 +1796,7 @@
}


/**

Check failure on line 1799 in Michelf/MarkdownExtra.php

View workflow job for this annotation

GitHub Actions / Linting - PHP 8.1 

Parameter #2 $replace of function str_replace expects array<string>|string, array<int, int> given.
* Abbreviations - strips abbreviations from text, stores titles in hash
* references.
* @param string $text
Expand Down
Loading