Skip to content

Add support for making tags focusable for improved assistive technologies support #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: lib
Choose a base branch
from
Open

Add support for making tags focusable for improved assistive technologies support #398

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
372b183
Merge pull request #1 from michelf/lib
sunnywalker Oct 16, 2018
060b9e5
make specific tags focusable for AT
sunnywalker Jan 5, 2024
3dc4a8b
Merge branch 'michelf:lib' into lib
sunnywalker Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Michelf/MarkdownExtra.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,12 @@ protected function teardown() {
*/
protected string $id_class_attr_nocatch_re = '\{(?>[ ]*[#.a-z][-_:a-zA-Z0-9=]+){1,}[ ]*\}';

/**
* Expression to use when determining whether to make a tag with an id focusable
* @var string
*/
protected $id_focusable_tags_re = '/h[1-6]/i';

/**
* Parse attributes caught by the $this->id_class_attr_catch_re expression
* and return the HTML-formatted list of attributes.
Expand Down Expand Up @@ -254,6 +260,10 @@ protected function doExtraAttributes($tag_name, $attr, $defaultIdValue = null, $
$attr_str = "";
if (!empty($id)) {
$attr_str .= ' id="'.$this->encodeAttribute($id) .'"';
// make specified tags focusable for assistive technologies anchor targets
if ($this->id_focusable_tags_re && preg_match($this->id_focusable_tags_re, $tag_name)) {
$attr_str .= ' tabindex="-1"';
}
}
if (!empty($classes)) {
$attr_str .= ' class="'. implode(" ", $classes) . '"';
Expand Down