You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a new hideEndTagSuggestions configuration option
in the CompletionConfiguration interface that allows users to disable
closing tag suggestions in HTML completions.
Previously, the html.suggest.html5 setting controlled whether HTML5
tags, properties, and values were suggested, but it did not affect
closing tag suggestions (e.g., </div>). Users who wanted to disable
the extension's suggestions entirely had no way to turn off these
end tag completions without disabling the entire extension.
Changes:
Added hideEndTagSuggestions?: boolean to the CompletionConfiguration
interface in htmlLanguageTypes.ts
Updated the collectCloseTagSuggestions function in htmlCompletion.ts
to check this setting and return early if end tag suggestions are
disabled
Added comprehensive tests to verify the setting works correctly in
various scenarios
The setting defaults to false (showing end tag suggestions) to
maintain backward compatibility with existing behavior.
Signed-off-by: Giovanni Magliocchetti <giovimag123@gmail.com>
add 5.6.0 entry for CompletionConfiguration.hideEndTagSuggestions
Signed-off-by: Giovanni Magliocchetti <giovimag123@gmail.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
de4a5a fix(bundler): `import.meta.url` and esm wrapper fixes (#23803)
What does this PR do?
Fixes printing import.meta.url and others with --bytecode. Fixes
#14954.
Fixes printing __toESM when output module format is CJS and input
module format is ESM.
The key change is that __toESM's isNodeMode parameter now depends on
the input module type (whether the importing file uses ESM syntax
like import/export) rather than the output format. This matches
Node.js ESM behavior where importing CommonJS from .mjs files always
wraps the entire module.exports object as the default export, ignoring __esModule markers.
How did you verify your code works?
Added comprehensive test suite in test/bundler/bundler_cjs.test.ts
with 23 tests covering:
Core Behaviors:
✅ Files using import syntax always get isNodeMode=1, which ignores __esModule markers and wraps the entire CJS module as
default
✅ This matches Node.js ESM semantics for importing CJS from .mjs
files
Without this PR (system bun): 22 pass, 1 fails (the one testing
that __esModule is ignored with import syntax + CJS format)
The failing test with system bun demonstrates the bug being fixed:
currently, format=cjs with import syntax still respects __esModule,
but it should ignore it (matching Node.js behavior).
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Co-authored-by: Claude Bot <claude-bot@bun.sh>
b86796 Remove unused EventLoopTimer.Arm return type (#23765)
Summary
The EventLoopTimer.Arm result from EventLoopTimer.fire() was being
ignored at both call sites. This PR removes the unused return type and
simplifies the code.
Changes
Changed EventLoopTimer.fire() to return void instead of Arm
Updated all 15 timer callback functions to return void
Removed the Arm type definition
Simplified the drainTimers() loop that was ignoring the return value
Updated both call sites in Timer.zig
Details
The .rearm functionality was unused - timers that need to reschedule
themselves (like DNS resolver) handle this by calling addTimer()/update() directly rather than relying on the return
value.
This change removes:
The Arm union enum type (3 lines)
All return .disarm and return .{ .rearm = ... } statements
The switch statement in drainTimers() that did nothing with the
return value
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.redirect.github.com>
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
8e34ec Fix IP address retrieval in server response (#23813)
2ebf6c Fix bounds check in Buffer writeBigInt64/writeBigUInt64 methods (#23781)
Summary
Fixed an unsigned integer underflow in the bounds check for writeBigInt64LE, writeBigInt64BE, writeBigUInt64LE, and writeBigUInt64BE methods.
Problem
When byteLength < 8, the bounds check offset > byteLength - 8 would
cause unsigned integer underflow (since both are size_t), resulting in
a large positive number that would pass the check. This allowed
out-of-bounds writes and caused ASAN use-after-poison errors.
Reproduction:
constbuf=Buffer.from("Hello World");constslice=buf.slice(0,5);slice.writeBigUInt64BE(4096n,10000);// ASAN error!
Solution
Added an explicit byteLength < 8 check before the subtraction to
prevent the underflow. The fix is applied to all four functions:
The getInternalProperties function in JSURLSearchParams.cpp was
using putDirect() to add properties to the result object. However, putDirect() cannot be used with property names that can be parsed as
array indices - JSC expects such properties to use indexed storage
instead.
The Fix
Replace putDirect() with putDirectMayBeIndex(), which
automatically handles both regular properties and numeric indices
Replace getDirect() with get() to properly retrieve values for
both types of properties
Test Plan
Added comprehensive tests to test/js/web/html/URLSearchParams.test.ts:
✅ Single numeric string keys
✅ Multiple numeric keys
✅ Mixed numeric and non-numeric keys
✅ Duplicate numeric keys
✅ Extra arguments (original crash case)
All tests pass, and the original crash no longer occurs.
1abfc0 fix: panic when overriding Set/Map size property with non-numeric value (#23787)
Summary
Fixes a panic that occurred when console.log() tried to format a Set
or Map instance with a non-numeric size property.
Issue
When a Set or Map subclass overrides the size property with a
non-numeric value (like a constructor function, string, or other
object), calling console.log() on the instance would trigger a panic:
In src/bun.js/ConsoleObject.zig, the Map and Set formatting code
called toInt32() directly on the size property value. This function
asserts that the value is not a Cell (objects/functions), causing a
panic when size was overridden with non-numeric values.
Solution
Changed both Map and Set formatting to use coerce(i32, globalThis)
instead of toInt32(). This properly handles non-numeric values using
JavaScript's standard type coercion rules and propagates any coercion
errors appropriately.
Test Plan
Added regression tests to test/js/bun/util/inspect.test.js that verify
Set and Map instances with overridden non-numeric size properties can
be inspected without panicking.
4142f8 Fix unnecessary reinterpret_casts from JSGlobalObject to Zig::GlobalObject (#23387)
(For internal tracking: fixes STAB-1384)
134341 Remove duplicate 'linked' option from sourcemap (#23737)
Bun bundler documentation duplicated the "linked" type for sourcemap.
What does this PR do?
Fix documentation mistake.
How did you verify your code works?
No code changes have been made.
642d04 Add --pass-with-no-tests flag to test runner (#23424)
Summary
This PR adds support for the --pass-with-no-tests CLI flag to the test
runner, addressing issue #20814.
With the latest v1.2.8 release, the test runner now fails when no tests
match a filter. While this is useful for agentic coding workflows, there
are legitimate cases where the previous behavior is preferred, such as
in monorepos where a standard test file pattern is used as a filter but
not all packages contain tests.
This flag makes the test runner behave like Jest and Vitest, exiting
with code 0 when no tests are found.
Changes
Added --pass-with-no-tests flag to CLI arguments in src/cli/Arguments.zig
Added pass_with_no_tests field to TestOptions struct in src/cli.zig
Updated test runner logic in src/cli/test_command.zig to respect the
flag
Added comprehensive tests in test/cli/test/pass-with-no-tests.test.ts
Test Plan
All new tests pass:
✅ --pass-with-no-tests exits with 0 when no test files found
✅ --pass-with-no-tests exits with 0 when filters match no tests
✅ Without flag, still exits with 1 when no tests found (preserves
existing behavior)
✅ --pass-with-no-tests still fails when actual tests fail
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Packages