Conversation
antagomir
left a comment
There was a problem hiding this comment.
Awesome! Just some suggestions.
|
Now the vignettes use DAA results from Maaslin3. While testing, I also added plotForest visualisation to the differential abundance chapter of OMA, for all the different methods. I could open a PR there. |
TuomasBorman
left a comment
There was a problem hiding this comment.
Some comments. Looks good!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #220 +/- ##
==========================================
+ Coverage 57.71% 61.39% +3.68%
==========================================
Files 21 22 +1
Lines 3493 3865 +372
==========================================
+ Hits 2016 2373 +357
- Misses 1477 1492 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TuomasBorman
left a comment
There was a problem hiding this comment.
Sorry for the delay. Here are couple final comments; most of them are thoughts and can be ignored if justified
TuomasBorman
left a comment
There was a problem hiding this comment.
Awesome, thank you!
Hi!
The plotForest viz is ready to be shared! (check vignettes for usage)
It features methods for both (Tree)SE and dataframes containing statistical results. All relevant variables (effects, CI upper and lower boundaries, pvals, id cols) are encoded by arguments for convenience and flexibility.
plotForest can be applied to both rowData and colData, with the option to add tree hierarchy and labels on the side, and also comparing between two groups (paired forest plot).
While minor aesthetic add-ons could be considered for future PRs, I think the main functionality is already there and is quite broad.
Happy to hear your comments,
Giulio