Independent Categories and Cross-posting panels#41
Open
mbradley wants to merge 1 commit intomicrodotblog:masterfrom
Open
Independent Categories and Cross-posting panels#41mbradley wants to merge 1 commit intomicrodotblog:masterfrom
mbradley wants to merge 1 commit intomicrodotblog:masterfrom
Conversation
Categories and Cross-posting in the compose window were mutually exclusive — showing one hid the other — and visibility reset on every new window. Now each panel has its own collection view and height constraint, both can be shown simultaneously, and visibility persists across new compose windows via UserDefaults. Also sizes checkbox items dynamically to fit their titles instead of using fixed column widths, and caps pane height at 120pt with scrolling beyond that.
Contributor
|
Excellent, thank you! |
Author
|
I like how this turned out — I think it'll fit my use of the app without being obtrusive, and I think there are some others who'll like it too. Happy to make any adjustments if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes Categories and Cross-posting in the compose window independently toggleable, so both can be shown at the same time. Persists their visibility across new compose windows via UserDefaults.
The crosspost panel gets its own programmatic collection view rather than sharing the categories one. Both panels size their checkbox items dynamically to fit the title text.
Closes #40, fixes #19
Still sitting with these changes for a bit before marking this ready.