fix base64 encoding mismatch for GET PKIOperation requests#250
Merged
jessepeterson merged 1 commit intomicromdm:mainfrom Jan 22, 2026
Merged
fix base64 encoding mismatch for GET PKIOperation requests#250jessepeterson merged 1 commit intomicromdm:mainfrom
jessepeterson merged 1 commit intomicromdm:mainfrom
Conversation
EncodeSCEPRequest was using base64.URLEncoding (with - and _) but SCEP servers expect base64.StdEncoding (with + and /). This caused "illegal base64 data" errors when the client sent GET requests to servers that don't support POST. Fixes micromdm#249
jessepeterson
approved these changes
Jan 22, 2026
Member
jessepeterson
left a comment
jessepeterson
left a comment
There was a problem hiding this comment.
lgtm, nice catch, and thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EncodeSCEPRequest was using base64.URLEncoding (with - and _) but SCEP servers expect base64.StdEncoding (with + and /). This caused "illegal base64 data" errors when the client sent GET requests to servers that don't support POST.
Fixes #249