Require that both RS256 and ES256 must be supported if the signature algorithm is not configured#333
Merged
sberyozkin merged 1 commit intomicroprofile:mainfrom Feb 27, 2025
sberyozkin:signature_algorithm_rs_rs256_es256
Merged
Require that both RS256 and ES256 must be supported if the signature algorithm is not configured#333sberyozkin merged 1 commit intomicroprofile:mainfrom sberyozkin:signature_algorithm_rs_rs256_es256
sberyozkin merged 1 commit intomicroprofile:mainfrom
sberyozkin:signature_algorithm_rs_rs256_es256
Conversation
Contributor
Author
|
I'll support ii with TCK tests once it is agreed via approvals |
Contributor
Author
|
There is a real lot of assertions in TCK tests expecting RS256 by default |
Contributor
Author
|
That said, the spec does not require anywhere that the signature algorithm must be injected as a string and not as a set of strings, so I may as well tweak TCK tests to expect a |
ayoho
approved these changes
Oct 17, 2024
…algorithm is not configured
Contributor
Author
|
I've now verified this PR with the smallrye-jwt mpjwt2.2 branch, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to align a situation with a non configured signature algorithm is managed with how it is done for the unconfigured decryption algorithm.
If a decryption algorithm is not configured, both
RSA-OAEPandRSA-OAEP-256encryped tokens must be accepted.Now, similarly, if a signature algorithm is not configured, both
RS256andES256signed tokens must be accepted.The end goal is to let an MP JWT Bridge JwtAuthenticationMechanismDefinition offer a consistent List representation for both signature and encryption properties
CC @ayoho @jimmy1wu