Sort list of projects before delivering to appsource #2041
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #2004 by ensuring projects are delivered in dependency order when publishing to AppSource. Previously, the Deliver action processed projects in the order returned by GetProjectsFromRepository, which doesn't account for dependencies between projects. This could cause failures when deploying dependent apps.
Key changes:
- Projects are now sorted using
AnalyzeProjectDependenciesbefore delivery, matching the build order - The sorted project list respects dependency relationships, ensuring base projects are delivered before dependent projects
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Actions/Deliver/Deliver.ps1
Outdated
| $projectBuildInfo = AnalyzeProjectDependencies -baseFolder $baseFolder -projects $projectList | ||
| $sortedProjectList = @() | ||
| foreach($BuildOrder in $projectBuildInfo.FullProjectsOrder) { | ||
| $sortedProjectList += $BuildOrder.projects | ||
| } |
There was a problem hiding this comment.
The new project sorting logic lacks test coverage. Consider adding tests to verify that projects are correctly sorted by dependencies, especially for multi-project repositories with complex dependency chains. The test should verify that the sorted order matches the build order returned by AnalyzeProjectDependencies.
spetersenms
left a comment
spetersenms
left a comment
There was a problem hiding this comment.
Copilots comments looks relevant, otherwise looks good.
3 participants
❔What, Why & How
Currently the Deliver function iterates over the AL-Go projects in the order they are returned by GetProjectsFromRepository. However, the output of this function is not sorted by dependencies. E.g. in BCApps the order would be:
This can be an issue when Publishing to AppSource if there are dependencies between the apps you are deploying.
Proposed solution: Deliver in the same order as the build. That would change the order to:
Related to issue: #2004
✅ Checklist