Fix validation on PR build to end-to-end test script for BCApps #2042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t script for BCApps
…-end test script for BCApps" This reverts commit cb178e0.
…e app and one test app are generated
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a brittle test validation in the BCApps end-to-end test script that was failing due to changing project counts in the BCApps repository. The solution makes the validation more flexible by checking for the presence of artifacts rather than an exact count.
- Replaces exact count validation (
Should -Be 1) with existence validation (Should -BeGreaterThan 0) - Adds separate validation for test app artifacts that were previously not explicitly validated
- Makes the test resilient to future changes in the number of projects in BCApps
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aholstrup1
approved these changes
Nov 27, 2025
spetersenms
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCApps test is failing because the number of projects there keeps changing.
Make the test a bit more generic to avoid having to change it often.