Update node samples #356
Draft
Update node samples #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date/nodejs-samples
…/microsoft/Agents into southworks/update/nodejs-samples
Member
tracyboehrer
left a comment
tracyboehrer
left a comment
There was a problem hiding this comment.
- auto-signin: I created a PR that removes the github handler from the sample
- Not everyone has a github repo to act against (most probably don't)
- Adding a GitHub OAuth handler is not well documented and took me a long time to figure out.
- You decide if we want to do the same thing here. If keep, we should at least document in the README
| @@ -18,8 +18,11 @@ type ApplicationTurnState = TurnState<ConversationState> | |||
| // in a cluster of Agent instances. | |||
| const storage = new MemoryStorage() | |||
|
|
|||
| const downloader = new AttachmentDownloader() | |||
Member
There was a problem hiding this comment.
Since the downloader isn't demonstrated in this sample, should it be created here?
Contributor
Author
There was a problem hiding this comment.
good question! Cecilia had added this in her branch so I wanted to keep it intact but perhaps this was just for testing something. I'll check!
…/microsoft/Agents into southworks/update/nodejs-samples
…com/microsoft/Agents into southworks/update/nodejs-samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-release for JS SDK we need to: