feat: Add header extender support to IndirectSignatureFactory#130
Merged
elantiguamsft merged 2 commits intomainfrom May 29, 2025
Merged
Conversation
Member
JeromySt
commented
May 29, 2025
JeromySt
commented
- Updated IndirectSignatureFactory methods to accept an optional ICoseHeaderExtender parameter for adding custom headers to COSE messages.
- Introduced ChainedCoseHeaderExtender to allow chaining multiple header extenders.
- Added unit tests for ChainedCoseHeaderExtender to ensure correct behavior and error handling.
- Updated IndirectSignatureFactory methods to accept an optional ICoseHeaderExtender parameter for adding custom headers to COSE messages. - Introduced ChainedCoseHeaderExtender to allow chaining multiple header extenders. - Added unit tests for ChainedCoseHeaderExtender to ensure correct behavior and error handling.
elantiguamsft
approved these changes
May 29, 2025
JeromySt
deleted the
users/jstatia/allow_header_modification_for_indirect_signatures
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.