Merged
Conversation
mayuram2
reviewed
Jun 3, 2025
mayuram2
left a comment
mayuram2
left a comment
There was a problem hiding this comment.
Should we consider renaming commonName to distinguishedName?
mayuram2
reviewed
Jun 3, 2025
mayuram2
left a comment
mayuram2
left a comment
There was a problem hiding this comment.
Instead of comparing the Format() strings, do we compare the RawData of both objects?
…icrosoft/CoseSignTool into user/elantigua/fix-common-name
JeromySt
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the
X509CommonNameValidatorfunctionality. Previously, the validator compared the entire subject of the signer, formatted as a anX500DistinguishedNameagainst the input. Like SignTool.exe's -n parameter, the validator now checks to make sure the common name string includes the provided input.