Skip to content

fix: netstandard2.0 compat and add Release build to CI #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elantiguamsft merged 1 commit into from
Mar 18, 2026
Merged

fix: netstandard2.0 compat and add Release build to CI #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ jobs:
dotnet test --no-restore CoseSignTool.MST.Plugin.Tests/CoseSignTool.MST.Plugin.Tests.csproj
dotnet test --no-restore CoseSignTool.IndirectSignature.Plugin.Tests/CoseSignTool.IndirectSignature.Plugin.Tests.csproj

# Build Release to catch issues the internal ADO pipeline would hit (e.g. netstandard2.0 API surface differences).
- name: Build Release
run: dotnet build --configuration Release CoseSignTool.sln

# List the contents of the working directory to make sure all the artifacts are there.
- name: List working directory
run: ${{ matrix.dir_command }}
Expand Down
2 changes: 1 addition & 1 deletion CoseSign1.Transparent.MST/MstServiceException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public static MstServiceException FromRequestFailedException(Azure.RequestFailed
{
var contentType = response.Headers.ContentType;

if (contentType?.Contains("cbor", StringComparison.OrdinalIgnoreCase) == true)
if (contentType?.IndexOf("cbor", StringComparison.OrdinalIgnoreCase) >= 0)
{
try
{
Expand Down
2 changes: 0 additions & 2 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,5 @@
<TestingPlatformDotnetTestSupport>true</TestingPlatformDotnetTestSupport>
<!-- Configure architecture for macOS ARM64 runners -->
<TestingPlatformArchitecture Condition="'$(OS)' == 'Unix' AND $([MSBuild]::IsOSPlatform('OSX'))">arm64</TestingPlatformArchitecture>
<!-- Alternative: Use RuntimeIdentifier on macOS -->
<RuntimeIdentifier Condition="'$(OS)' == 'Unix' AND $([MSBuild]::IsOSPlatform('OSX')) AND '$(RuntimeIdentifier)' == ''">osx-arm64</RuntimeIdentifier>
</PropertyGroup>
</Project>
Loading