Skip to content

index factory bugfix #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SylviaZiyuZhang wants to merge 3 commits into
base: cpp_main
Choose a base branch
from
Open

index factory bugfix #677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e6a6a9
index factory bugfix
SylviaZiyuZhang Oct 9, 2025
bbf896a
Merge branch 'microsoft:main' into main
SylviaZiyuZhang Nov 5, 2025
082c99d
Change uint32_t to std::uint32_t in ANNException
SylviaZiyuZhang Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/ann_exception.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class ANNException : public std::runtime_error
public:
DISKANN_DLLEXPORT ANNException(const std::string &message, int errorCode);
DISKANN_DLLEXPORT ANNException(const std::string &message, int errorCode, const std::string &funcSig,
const std::string &fileName, uint32_t lineNum);
const std::string &fileName, std::uint32_t lineNum);

private:
int _errorCode;
Expand Down
4 changes: 2 additions & 2 deletions src/index_factory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ std::unique_ptr<AbstractIndex> IndexFactory::create_instance()
if (_config->data_strategy == DataStoreStrategy::MEMORY && _config->pq_dist_build)
{
pq_data_store =
construct_pq_datastore<data_type>(_config->data_strategy, num_points + _config->num_frozen_pts, dim,
construct_pq_datastore<data_type>(_config->data_strategy, num_points, dim,
_config->metric, _config->num_pq_chunks, _config->use_opq);
}
else
Expand All @@ -138,7 +138,7 @@ std::unique_ptr<AbstractIndex> IndexFactory::create_instance()
(size_t)(defaults::GRAPH_SLACK_FACTOR * 1.05 *
(_config->index_write_params == nullptr ? 0 : _config->index_write_params->max_degree));
std::unique_ptr<AbstractGraphStore> graph_store =
construct_graphstore(_config->graph_strategy, num_points + _config->num_frozen_pts, max_reserve_degree);
construct_graphstore(_config->graph_strategy, num_points, max_reserve_degree);

// REFACTOR TODO: Must construct in-memory PQDatastore if strategy == ONDISK and must construct
// in-mem and on-disk PQDataStore if strategy == ONDISK and diskPQ is required.
Expand Down