ODAA MicroHack: Documentation improvements and diagrams#283
ODAA MicroHack: Documentation improvements and diagrams#283cpinotossi wants to merge 96 commits intomicrosoft:mainfrom
Conversation
- Add Deploy-PerfTest.ps1 script for automated performance testing - Add perf-test-odaa-simplified.md with streamlined walkthrough - Update cleanup-odaa-and-destroy.ps1 with exclusion options and WhatIf support - Update deploy-base-pods.ps1 with cluster exclusions and auto-stop/start
There was a problem hiding this comment.
remove all files which are not inside your folder "10_Oracle_on-Azure" from your PR
There was a problem hiding this comment.
in database configuration checks there is a hostname in the connection information. This should be avoided. Instead give instructions how to build the connection string for your personal environment, or provide a script which returns the information dynamically.
Also tenant or resource IDs do not belong into this repo. Please remove them or make them non-readable.
There was a problem hiding this comment.
avoid providing tenant id/name information wherever possible.
There was a problem hiding this comment.
avoid Tenant_id and client_id values
There was a problem hiding this comment.
you probably want to replace the pointer to your private fork with the official repo URL for merging
There was a problem hiding this comment.
host and service endpoints should not be provided
There was a problem hiding this comment.
avoid providing tenancy identifers
There was a problem hiding this comment.
host name should be made unreadable/not provided
There was a problem hiding this comment.
existing users should not be identifiable
There was a problem hiding this comment.
Is it intended to have this zip file in the repo?
There was a problem hiding this comment.
some markup meta information appear in the markup preview. Maybe there is something broken?
There was a problem hiding this comment.
avoid providing n existing compartment id
There was a problem hiding this comment.
avoid providing subscription id and endoint information
There was a problem hiding this comment.
avoid providing storage account name
There was a problem hiding this comment.
avoid providing UPN and group ids
There was a problem hiding this comment.
compartment id should not be provided
There was a problem hiding this comment.
subscription ids should be avoided
There was a problem hiding this comment.
avoid providing subscription ids
There was a problem hiding this comment.
avoid providing tenant id and client id
There was a problem hiding this comment.
avoid providing tenant id
There was a problem hiding this comment.
avoid providing host name
There was a problem hiding this comment.
avoid providing host names
There was a problem hiding this comment.
do not include files outside your folder 10_Oracle_on_Azure in this PR
skiddder
left a comment
skiddder
left a comment
There was a problem hiding this comment.
do not provide hostnames, tenant ids or other potentially sensitive data in this repository
|
@cpinotossi please check again and resolve the conflicts. |
|
@cpinotossi let me know if you need help wrt conflict resolution |
6 participants
Overview
This PR includes updates to the ODAA MicroHack documentation:
Changes
Related