FIX: Add closing tag to IISServer-10.0-3.5 OrgSettings#1531
Open
FrederickGeek8 wants to merge 1 commit intomicrosoft:devfrom
Open
FIX: Add closing tag to IISServer-10.0-3.5 OrgSettings#1531FrederickGeek8 wants to merge 1 commit intomicrosoft:devfrom
FrederickGeek8 wants to merge 1 commit intomicrosoft:devfrom
Conversation
Commit b07514f mistakenly removed the XML self-closing tag from the default IISServer-10.0-3.5 OrgSetting file. As a result, IISServer configuration failed due to unclosed XML tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description:
Commit b07514f, as part of PR #1517 and included in v4.28.0, mistakenly removed
/from the XML self-closing tag inside the default IISServer-10.0-3.5 OrgSetting file -- making it an unclosed XML tag. As a result, IISServer configuration will always fail due to unclosed XML tags.This PR is a small one -- it adds the
/back to the IISServer-10.0-2.5 default settings file. Running IISServer configuration -- at least on my machines -- works again.This Pull Request (PR) fixes the following issues:
This fully resolves the issues brought up in Issue #1504 that were intended to be solved in PR #1517.
Task list:
Further notes:
The removal of
/in b07514f did not affect 3.4 (only 3.5) because 3.4 was using full-closing XML tags, versus 3.5 which used self-closing XML tags.It is perhaps worth noting that self-closing tags are used in several places for
OrganizationSettings, such as in the IE11 STIG, so 3.4's usage of non-self-closing tags for an empty "body" seems a little out-of-the-ordinary. It's a nit-pick, but I would maybe like 3.4's configuration to be changed to a self-closing tag inline with the other XML files I've seen in this repo.