Skip to content

[Peek] Terminate Preview Handlers Processes #40116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

davidegiacometti
Copy link
Collaborator

@davidegiacometti davidegiacometti commented Jun 18, 2025

Summary of the Pull Request

This is an attempt to release Preview Handlers instantiated by Peek and close the related processe.

⚠️ Note that even if the PR improve the current behavior, the solution doesn't work 100% of times.
I noticed that sometimes the process gets leaked also when Preview Handler is used in Explorer 🤔

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • Ported the same fix applied to CmdPal to ensure the process is terminated gracefully instead of being killed: [CmdPal] Close Gracefully #39589
  • Attempt to cleanup Preview Handlers and close the relative process

Validation Steps Performed

Tested manually:

  • Preview through some Excel and Word files
  • Close Peek window
  • Excel and Word processes are closed

@davidegiacometti davidegiacometti force-pushed the users/davidegiacometti/peek-terminate-previewhandler branch from 1d5879c to 419b463 Compare June 18, 2025 20:24
@davidegiacometti davidegiacometti marked this pull request as draft June 18, 2025 20:27
@davidegiacometti davidegiacometti self-assigned this Jun 21, 2025
@davidegiacometti davidegiacometti marked this pull request as ready for review June 21, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant