Skip to content

Conversation

@RedCMD
Copy link

@RedCMD RedCMD commented Jan 28, 2026

@jeffy-g
Copy link

jeffy-g commented Jan 28, 2026

Nice fix, thanks!

One question: will this also be propagated to VS Code’s derived JavaScript/JSX TextMate grammars? VS Code notes that JavaScript.tmLanguage.json is derived from TypeScriptReact.tmLanguage from this repo.

Currently, in .js files /// <reference ... preserve="true" /> still falls back to a regular line comment highlight. If propagation is out of scope here, should we track it as a follow-up in VS Code?

@RedCMD
Copy link
Author

RedCMD commented Jan 28, 2026

https://github.com/microsoft/vscode/blob/main/extensions/javascript/syntaxes/Readme.md
claims it'll propagate
and this PR seems to suggest so microsoft/vscode#232238

the bigger problem is that the grammar in this repo hasn't been updated in years

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

typescript-basics: fix highlighting for triple-slash reference directives with preserve="true"

2 participants