Skip to content

add weave tracer #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

add weave tracer #277

wants to merge 33 commits into from
+693 −100

Conversation

@acured
Copy link
Collaborator

@acured acured commented Nov 5, 2025

No description provided.

Hao Ni (CSI Interfusion Co Ltd) and others added 23 commits November 5, 2025 16:02
add weave tracer
5d8b921
fix _convert_weave_call_to_readable_span
296c610
Merge remote-tracking branch 'upstream/main' into hao/add_weave_tracer
40c73a3
add otel provider
b2d2648
Merge remote-tracking branch 'upstream/main' into hao/add_weave_tracer
48aca6c
fix lint
12d1164
fix lint
e4402d4
add uv fix
f9261ba
fix lint
434e13a
add weave into workflow
4f2cc47
fix tests.yml
8085a73
@acured
Merge remote-tracking branch 'upstream/main' into hao/add_weave_tracer
5a5a3f5
@acured
fix uvlock
b5ad8ea
@acured
weave tracer inherits from OtelTracer
b9314b7
@acured
remove _weaveclient
3d02b37
@acured
fix lint
f257624
@acured
fix style
4f2c3fd
@acured
fix lint in test
9d37fe9
@acured
Merge remote-tracking branch 'upstream/main' into hao/add_weave_tracer
f270717
@acured
remove weave package from javasript test step
503ff4e
@acured
add weave group in js test
6bcc22c
@acured
revert..
13161e3
@acured
change weave to optional
5850fa7
@acured acured marked this pull request as ready for review November 20, 2025 07:10
@acured acured requested a review from ultmaster November 20, 2025 07:10
@ultmaster
Copy link
Contributor

ultmaster commented Nov 20, 2025

Generally I don't think it's necessary to support non-OTLP path for advanced tracers. You can first check whether the store has OTLP capability within init_worker(), which is added in a PR merged yesterday. If the store has such capability, you can use initialize the tracer so that it writes to the store.

You can inject the rollout_id and attempt_id if you have control over get_tracer(), or you can use the augmented OTLP exporter to modify the traces when export.

@acured acured marked this pull request as draft November 21, 2025 09:58
@acured acured marked this pull request as ready for review November 27, 2025 08:58
ultmaster
ultmaster reviewed Nov 27, 2025
View reviewed changes
tests/tracer/test_weave.py

async def add_span(self, span: Span) -> Span:
self.spans.append(span)
return span # 返回同类型
Copy link
Contributor

@ultmaster ultmaster Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove chinese comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ultmaster ultmaster ultmaster left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@acured @ultmaster