add support for Windows platform in Copilot CLI path resolution#1
Closed
YoavLax wants to merge 1 commit intomicrosoft:mainfrom
Closed
add support for Windows platform in Copilot CLI path resolution#1YoavLax wants to merge 1 commit intomicrosoft:mainfrom
YoavLax wants to merge 1 commit intomicrosoft:mainfrom
Conversation
c6e7776 to
9da62c5
Compare
|
Sure buddy I'm having my end sem examination, I would be free within 3-4 days to get back on project ,I'm quite happy about that people trying to use and test it, I'm sorry that it was limited to only my college id as i didn't thought others would bother using it but happy to be proven wrong. |
Collaborator
|
Hey @YoavLax — thanks for flagging this and for the contribution! 🙏 We've since landed comprehensive Windows support in
Since this is fully covered now, I'm closing this PR. Really appreciate you surfacing the issue early — it helped inform the direction we took! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Windows support for Copilot CLI detection
Problem
The Copilot CLI detection logic only worked on Unix/macOS systems. Windows users would get "Copilot CLI not found" errors even with Copilot installed.
Solution
Added Windows support by returning
"copilot"on Windows platforms and letting the Copilot SDK resolve it from PATH. This matches the pattern used in other working implementations.Changes:
src/services/instructions.ts: Added Windows check infindCopilotCliPath()src/services/evaluator.ts: Added Windows check infindCopilotCliPath()Implementation