Skip to content

Add support for configuration in RunNotebook job#18

Open
LeoAda wants to merge 1 commit intomicrosoft:mainfrom
LeoAda:main
Open

Add support for configuration in RunNotebook job#18
LeoAda wants to merge 1 commit intomicrosoft:mainfrom
LeoAda:main

Conversation

@LeoAda
Copy link

@LeoAda LeoAda commented Apr 17, 2025

Add configuration as parameter to run notebook.

@ambika-garg ambika-garg requested a review from Copilot April 18, 2025 22:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a new parameter, job_config, to the RunNotebook job. The changes include propagating this new parameter in the operator and updating the hook to include it in the API request payload.

  • In the operator, job_config is added to the list of template fields and is captured in the init method and passed to the run_fabric_item hook call.
  • In the hook, the run_fabric_item method signature and JSON payload construction are updated to include job_config for RunNotebook job types.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/apache_airflow_microsoft_fabric_plugin/operators/fabric.py Updated operator class to accept and pass job_config as a parameter
src/apache_airflow_microsoft_fabric_plugin/hooks/fabric.py Updated hook method to accept job_config and include it in the API request payload
Comments suppressed due to low confidence (1)

src/apache_airflow_microsoft_fabric_plugin/hooks/fabric.py:229

  • New functionality handling job_config is added; please ensure that there is sufficient test coverage for scenarios both with and without job_config provided.
if job_config and job_type == "RunNotebook":

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant