Add support for configuration in RunNotebook job#18
Open
LeoAda wants to merge 1 commit intomicrosoft:mainfrom
Open
Add support for configuration in RunNotebook job#18LeoAda wants to merge 1 commit intomicrosoft:mainfrom
LeoAda wants to merge 1 commit intomicrosoft:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a new parameter, job_config, to the RunNotebook job. The changes include propagating this new parameter in the operator and updating the hook to include it in the API request payload.
- In the operator, job_config is added to the list of template fields and is captured in the init method and passed to the run_fabric_item hook call.
- In the hook, the run_fabric_item method signature and JSON payload construction are updated to include job_config for RunNotebook job types.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/apache_airflow_microsoft_fabric_plugin/operators/fabric.py | Updated operator class to accept and pass job_config as a parameter |
| src/apache_airflow_microsoft_fabric_plugin/hooks/fabric.py | Updated hook method to accept job_config and include it in the API request payload |
Comments suppressed due to low confidence (1)
src/apache_airflow_microsoft_fabric_plugin/hooks/fabric.py:229
- New functionality handling job_config is added; please ensure that there is sufficient test coverage for scenarios both with and without job_config provided.
if job_config and job_type == "RunNotebook":
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configuration as parameter to run notebook.