Revert durable task scheduler Azure Functions changes#15683
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15683Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15683" |
There was a problem hiding this comment.
Pull request overview
Reverts the Durable Task Scheduler (DTS) additions that were introduced into Aspire.Hosting.Azure.Functions (per commit 212d44411 / PR #13711) to restore a green build by removing the DTS resource API surface, related tests, docs, and playground sample.
Changes:
- Removes Durable Task Scheduler / Task Hub resource types and extension methods from
Aspire.Hosting.Azure.Functions. - Deletes the associated unit tests and DTS-specific playground app.
- Cleans up repo-wide references (solution entries + package version pins) that were only used by the removed playground.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Hosting.Azure.Tests/DurableTaskResourceExtensionsTests.cs | Removes tests that validated DTS resource behavior (connection strings, manifest exclusions, emulator env vars). |
| src/Aspire.Hosting.Azure.Functions/README.md | Removes the DTS section and examples from the Azure Functions hosting README. |
| src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskSchedulerResource.cs | Deletes the DTS scheduler resource type (endpoints + connection string expression). |
| src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskSchedulerEmulatorResource.cs | Deletes the emulator container resource wrapper for the scheduler. |
| src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskSchedulerEmulatorContainerImageTags.cs | Deletes DTS emulator container image tag constants. |
| src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskSchedulerConnectionStringAnnotation.cs | Deletes the annotation used to supply an existing scheduler connection string. |
| src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskResourceExtensions.cs | Deletes the public extension methods that added/configured DTS resources (scheduler + task hubs). |
| src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskHubResource.cs | Deletes the task hub resource that composed scheduler connection string + TaskHub. |
| src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskHubNameAnnotation.cs | Deletes the annotation used to override task hub names. |
| playground/AzureFunctionsWithDts/AzureFunctionsWithDts.Functions/host.json | Deletes DTS-specific Functions host configuration for durableTask extension. |
| playground/AzureFunctionsWithDts/AzureFunctionsWithDts.Functions/Properties/launchSettings.json | Deletes DTS playground Functions launch settings. |
| playground/AzureFunctionsWithDts/AzureFunctionsWithDts.Functions/Program.cs | Deletes DTS playground Functions app entrypoint. |
| playground/AzureFunctionsWithDts/AzureFunctionsWithDts.Functions/MyOrchestrationTrigger.cs | Deletes DTS playground orchestration/activity trigger sample. |
| playground/AzureFunctionsWithDts/AzureFunctionsWithDts.Functions/AzureFunctionsWithDts.Functions.csproj | Deletes the DTS playground Functions project (including DurableTask packages). |
| playground/AzureFunctionsWithDts/AzureFunctionsWithDts.AppHost/Properties/launchSettings.json | Deletes DTS playground AppHost launch settings. |
| playground/AzureFunctionsWithDts/AzureFunctionsWithDts.AppHost/Program.cs | Deletes DTS playground AppHost wiring that used AddDurableTaskScheduler and task hub env vars. |
| playground/AzureFunctionsWithDts/AzureFunctionsWithDts.AppHost/AzureFunctionsWithDts.AppHost.csproj | Deletes the DTS playground AppHost project. |
| Directory.Packages.props | Removes package version pins that were only used by the deleted DTS playground apps. |
| Aspire.slnx | Removes the DTS playground projects from the solution. |
| @@ -47,64 +47,6 @@ var app = builder.Build(); | |||
| app.Run(); | |||
| ``` | |||
|
|
|||
There was a problem hiding this comment.
The README no longer contains an "Additional documentation" section after removing the Durable Task Scheduler content. Most hosting integration READMEs include this section (e.g., links to aspire.dev and Microsoft Learn), so consider re-adding it here with at least Azure Functions + Aspire integration links before "Feedback & contributing".
| ## Additional documentation | |
| * https://aspire.dev/integrations/cloud/azure/azure-functions/ | |
| * https://learn.microsoft.com/azure/azure-functions/dotnet-aspire |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
new PR #15684 |
Description
Reverts
212d44411(Addition of Durable Task Scheduler resources to Azure Functions host library (#13711)).This backs out the Durable Task Scheduler resource work from
Aspire.Hosting.Azure.Functionsbecause it is currently breaking the build.Validation:
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: