Skip to content

Revert durable task scheduler Azure Functions changes#15683

Merged
davidfowl merged 1 commit intomainfrom
revert-durable-task-pr-13711
Mar 28, 2026
Merged

Revert durable task scheduler Azure Functions changes#15683
davidfowl merged 1 commit intomainfrom
revert-durable-task-pr-13711

Conversation

@davidfowl
Copy link
Copy Markdown
Contributor

Description

Reverts 212d44411 (Addition of Durable Task Scheduler resources to Azure Functions host library (#13711)).

This backs out the Durable Task Scheduler resource work from Aspire.Hosting.Azure.Functions because it is currently breaking the build.

Validation:

  • Not run at request of reviewer/authoring engineer.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@davidfowl davidfowl requested a review from eerhardt as a code owner March 28, 2026 20:21
Copilot AI review requested due to automatic review settings March 28, 2026 20:21
@davidfowl davidfowl merged commit 9f1d2e2 into main Mar 28, 2026
5 checks passed
@davidfowl davidfowl deleted the revert-durable-task-pr-13711 branch March 28, 2026 20:21
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15683

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15683"

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the Durable Task Scheduler (DTS) additions that were introduced into Aspire.Hosting.Azure.Functions (per commit 212d44411 / PR #13711) to restore a green build by removing the DTS resource API surface, related tests, docs, and playground sample.

Changes:

  • Removes Durable Task Scheduler / Task Hub resource types and extension methods from Aspire.Hosting.Azure.Functions.
  • Deletes the associated unit tests and DTS-specific playground app.
  • Cleans up repo-wide references (solution entries + package version pins) that were only used by the removed playground.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/Aspire.Hosting.Azure.Tests/DurableTaskResourceExtensionsTests.cs Removes tests that validated DTS resource behavior (connection strings, manifest exclusions, emulator env vars).
src/Aspire.Hosting.Azure.Functions/README.md Removes the DTS section and examples from the Azure Functions hosting README.
src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskSchedulerResource.cs Deletes the DTS scheduler resource type (endpoints + connection string expression).
src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskSchedulerEmulatorResource.cs Deletes the emulator container resource wrapper for the scheduler.
src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskSchedulerEmulatorContainerImageTags.cs Deletes DTS emulator container image tag constants.
src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskSchedulerConnectionStringAnnotation.cs Deletes the annotation used to supply an existing scheduler connection string.
src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskResourceExtensions.cs Deletes the public extension methods that added/configured DTS resources (scheduler + task hubs).
src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskHubResource.cs Deletes the task hub resource that composed scheduler connection string + TaskHub.
src/Aspire.Hosting.Azure.Functions/DurableTask/DurableTaskHubNameAnnotation.cs Deletes the annotation used to override task hub names.
playground/AzureFunctionsWithDts/AzureFunctionsWithDts.Functions/host.json Deletes DTS-specific Functions host configuration for durableTask extension.
playground/AzureFunctionsWithDts/AzureFunctionsWithDts.Functions/Properties/launchSettings.json Deletes DTS playground Functions launch settings.
playground/AzureFunctionsWithDts/AzureFunctionsWithDts.Functions/Program.cs Deletes DTS playground Functions app entrypoint.
playground/AzureFunctionsWithDts/AzureFunctionsWithDts.Functions/MyOrchestrationTrigger.cs Deletes DTS playground orchestration/activity trigger sample.
playground/AzureFunctionsWithDts/AzureFunctionsWithDts.Functions/AzureFunctionsWithDts.Functions.csproj Deletes the DTS playground Functions project (including DurableTask packages).
playground/AzureFunctionsWithDts/AzureFunctionsWithDts.AppHost/Properties/launchSettings.json Deletes DTS playground AppHost launch settings.
playground/AzureFunctionsWithDts/AzureFunctionsWithDts.AppHost/Program.cs Deletes DTS playground AppHost wiring that used AddDurableTaskScheduler and task hub env vars.
playground/AzureFunctionsWithDts/AzureFunctionsWithDts.AppHost/AzureFunctionsWithDts.AppHost.csproj Deletes the DTS playground AppHost project.
Directory.Packages.props Removes package version pins that were only used by the deleted DTS playground apps.
Aspire.slnx Removes the DTS playground projects from the solution.

@@ -47,64 +47,6 @@ var app = builder.Build();
app.Run();
```

Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README no longer contains an "Additional documentation" section after removing the Durable Task Scheduler content. Most hosting integration READMEs include this section (e.g., links to aspire.dev and Microsoft Learn), so consider re-adding it here with at least Azure Functions + Aspire integration links before "Feedback & contributing".

Suggested change
## Additional documentation
* https://aspire.dev/integrations/cloud/azure/azure-functions/
* https://learn.microsoft.com/azure/azure-functions/dotnet-aspire

Copilot uses AI. Check for mistakes.
adamint pushed a commit to adamint/aspire that referenced this pull request Mar 28, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@davidfowl
Copy link
Copy Markdown
Contributor Author

new PR #15684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants