[release/13.2] Deprecate Aspire.Hosting.NodeJs in CLI integration listings#15686
Open
aspire-repo-bot[bot] wants to merge 4 commits intorelease/13.2from
Open
[release/13.2] Deprecate Aspire.Hosting.NodeJs in CLI integration listings#15686aspire-repo-bot[bot] wants to merge 4 commits intorelease/13.2from
aspire-repo-bot[bot] wants to merge 4 commits intorelease/13.2from
Conversation
Add Aspire.Hosting.NodeJs to the deprecated packages filter in both BundleNuGetPackageCache and NuGetPackageCache so it no longer appears in 'aspire add' integration listings. The replacement package is Aspire.Hosting.JavaScript. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove duplicated s_deprecatedPackages HashSet from both BundleNuGetPackageCache and NuGetPackageCache. Consolidate into a single DeprecatedPackages.All in NuGetPackageCache.cs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace mutable HashSet with FrozenSet and expose via DeprecatedPackages.IsDeprecated() to prevent accidental mutation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15686Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15686" |
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
Contributor
|
🎬 CLI E2E Test Recordings — 52 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23697743523 |
adamint
approved these changes
Mar 29, 2026
adamint
reviewed
Mar 29, 2026
| { | ||
| "Aspire.Hosting.Dapr", | ||
| "Aspire.Hosting.NodeJs" | ||
| }.ToFrozenSet(StringComparer.OrdinalIgnoreCase); |
Member
There was a problem hiding this comment.
nit: use one of the StringComparers
mitchdenny
approved these changes
Mar 29, 2026
This was referenced Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #15677 to release/13.2
/cc @davidfowl
Customer Impact
The agent keeps picking the old deprecated integration when attempting to add integration because its still in the list
Testing
Added tests.
Risk
Low, you can always show deprecated packages.
Regression?
No