Skip to content

Fix TypeScript starter restore failure by stopping pipeline early (Fixes #15420) #15694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michalkalit wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

Fix TypeScript starter restore failure by stopping pipeline early (Fixes #15420) #15694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Aspire.Cli/Projects/GuestAppHostProject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,8 @@ await GenerateCodeViaRpcAsync(
cancellationToken);

// Step 5: Install dependencies using GuestRuntime (best effort - don't block code generation)
await InstallDependenciesAsync(directory, rpcClient, cancellationToken);
return true;
var result = await InstallDependenciesAsync(directory, rpcClient, cancellationToken);
return (result == 0);
}
finally
{
Expand Down
4 changes: 4 additions & 0 deletions src/Aspire.Cli/Templating/CliTemplateFactory.TypeScriptStarterTemplate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ private async Task<TemplateResult> ApplyTypeScriptStarterTemplateAsync(CallbackT
if (appHostProject is not IGuestAppHostSdkGenerator guestProject)
{
_interactionService.DisplayError("Automatic 'aspire restore' is unavailable for the new TypeScript starter project because no TypeScript AppHost SDK generator was found.");
if (Directory.Exists(outputPath))
Copy link
Copy Markdown
Author

@michalkalit michalkalit Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I’m considering: if the output directory already exists, we shouldn’t delete it on restore failure.
I can update the PR to only delete directories created by the template.
Let me know if you prefer that approach.

{
Directory.Delete(outputPath, true);
}
return new TemplateResult(ExitCodeConstants.FailedToBuildArtifacts, outputPath);
}

Expand Down
Loading