Skip to content

add test specs #15845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmcilvaney wants to merge 1 commit into
base: tomls/base/main
Choose a base branch
from
+120 −1
Open

add test specs #15845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/comps/azurelinux-release/azurelinux-release.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
# or 0 for RC and stable releases
%define is_development 1

# TODO(azl): review
# TODO(azl): review -- set to a future date for now, fix before release
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says “set to a future date for now”, but eol_date is currently 1900-01-01 (a past date). Please update the comment to match the current placeholder strategy, or update eol_date if the intent really is to use a future placeholder.

Suggested change
# TODO(azl): review -- set to a future date for now, fix before release
# TODO(azl): review -- placeholder EOL date; 1900-01-01 indicates EOL not yet finalized

Copilot uses AI. Check for mistakes.
%define eol_date 1900-01-01

Check failure on line 9 in base/comps/azurelinux-release/azurelinux-release.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Placeholder EOL date 1900-01-01 produces an invalid SUPPORT_END value and is marked as TODO.

%define dist_version_major 4
%define dist_version_minor 0
Expand Down Expand Up @@ -35,7 +35,7 @@
Version: 4.0
# The numbering is 0.<r> before a given release is released,
# and then just <r>.
Release: %autorelease %[0%{?is_development} ? "-p" : ""]

Check warning on line 38 in base/comps/azurelinux-release/azurelinux-release.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Prerelease builds should use a tilde in Version for correct ordering; current prerelease signal is only in Release. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/)
License: MIT
URL: https://aka.ms/azurelinux

Expand Down Expand Up @@ -97,7 +97,7 @@


%description identity-basic
Provides the necessary files for a Azure Linux installation that is not identifying

Check notice on line 100 in base/comps/azurelinux-release/azurelinux-release.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Wrap description lines to 80 characters or less. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description)

Check notice on line 100 in base/comps/azurelinux-release/azurelinux-release.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Grammar%3A use 'an Azure Linux' instead of 'a Azure Linux' in descriptions.
itself as a particular variant.
%endif

Expand Down Expand Up @@ -199,12 +199,12 @@


%package identity-wsl
Summary: Package providing the identity for Azure Linux WSL.

Check warning on line 202 in base/comps/azurelinux-release/azurelinux-release.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Summary for identity-wsl ends with a period; Summary should not end with a period. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections)

RemovePathPostfixes: .wsl
Provides: azurelinux-release-identity = %{version}-%{release}
Conflicts: azurelinux-release-identity
Requires(meta): azurelinux-release-container = %{version}-%{release}

Check failure on line 207 in base/comps/azurelinux-release/azurelinux-release.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

identity-wsl subpackage Requires(meta) points to azurelinux-release-container instead of azurelinux-release-wsl%2C which mismatches the variant package.


%description identity-wsl
Expand Down Expand Up @@ -384,7 +384,7 @@
ln -s --relative %{buildroot}%{_swidtagdir} %{buildroot}%{_sysconfdir}/swid/swidtags.d/microsoft.com

# Install DNF 5 configuration defaults
install -Dm0644 %{SOURCE16} -t %{buildroot}%{_prefix}/share/dnf5/libdnf.conf.d/

Check notice on line 387 in base/comps/azurelinux-release/azurelinux-release.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Use %{_datadir} instead of %{_prefix}/share for data paths (dnf5 config install/%files). (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/)


%files common
Expand Down Expand Up @@ -418,7 +418,7 @@

%if %{with basic}
%files
%files identity-basic

Check failure on line 421 in base/comps/azurelinux-release/azurelinux-release.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

identity-basic subpackage is independent but does not include a %license entry for applicable license text. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing)
%{_prefix}/lib/os-release.basic
%endif

Expand Down
119 changes: 119 additions & 0 deletions base/comps/go-md2man/go-md2man.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,119 @@
Summary: Converts markdown into roff (man pages)
Name: go-md2man

Check warning on line 2 in base/comps/go-md2man/go-md2man.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Go binaries should set ExclusiveArch to %{golang_arches} (or %{golang_arches_future}). (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/Golang/)
Version: 2.0.2
Release: 1%{?dist}

Check notice on line 4 in base/comps/go-md2man/go-md2man.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Consider using Release%3A %autorelease for automated release numbering. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/)
Comment on lines +1 to +4
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This spec file is added without any corresponding component definition (e.g., base/comps/go-md2man/go-md2man.comp.toml or an entry in base/comps/components.toml). As-is, go-md2man will not be picked up by includes = ["**/*.comp.toml"], so it won’t build as part of the distro. Add a .comp.toml for the component (or otherwise wire it into the component set), or move/remove this file if it’s only intended as a test artifact.

Copilot uses AI. Check for mistakes.
License: MIT

Check failure on line 5 in base/comps/go-md2man/go-md2man.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

License tag must include cumulative SPDX expression covering vendored modules; only MIT is listed. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/Golang/)
Vendor: Microsoft Corporation

Check failure on line 6 in base/comps/go-md2man/go-md2man.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Forbidden Vendor tag is present. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections)
Distribution: Azure Linux
Group: Tools/Container

Check warning on line 8 in base/comps/go-md2man/go-md2man.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Deprecated Group tag is used. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections)
URL: https://github.com/cpuguy83/go-md2man
Source0: https://github.com/cpuguy83/go-md2man/archive/v%{version}.tar.gz#/go-md2man-%{version}.tar.gz

Check failure on line 10 in base/comps/go-md2man/go-md2man.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Go packages must vendor dependencies and include go-vendor-tools.toml/vendor archive; none are declared. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/Golang/)
Comment on lines +1 to +10
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repository convention is to avoid forking/hand-coding specs for upstream packages and instead use upstream specs + overlays; local specs are currently only used for Azure Linux-originating components (e.g., azurelinux-release, azurelinux-repos). If go-md2man is not Azure Linux-originating, please switch this to an upstream component with overlays rather than introducing a local .spec.

Copilot uses AI. Check for mistakes.
BuildRequires: golang

Check failure on line 11 in base/comps/go-md2man/go-md2man.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Missing BuildRequires%3A go-vendor-tools for required vendoring/license tooling. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/Golang/)

Check failure on line 11 in base/comps/go-md2man/go-md2man.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Missing required BuildRequires%3A go-rpm-macros for Go packages. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/Golang/)
BuildRequires: which
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BuildRequires: which is not used anywhere in this spec (no invocation of which in build/install/check). Please drop the unused BuildRequires to keep the dependency set minimal.

Suggested change
BuildRequires: which

Copilot uses AI. Check for mistakes.
# required packages on install
Requires: /bin/sh
Provides: golang-github-cpuguy83-md2man

Check failure on line 15 in base/comps/go-md2man/go-md2man.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Missing bundled(golang(IMPORT_PATH)) Provides for vendored modules. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/Golang/)
Provides: go-go-md2man = %{version}-%{release}

%description
Converts markdown into roff (man pages)

%define OUR_GOPATH %{_topdir}/.gopath
Vendor: Microsoft Corporation

Check failure on line 22 in base/comps/go-md2man/go-md2man.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Vendor tag appears again after %description and must not be used. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections)
Distribution: Azure Linux
Comment on lines +22 to +23
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vendor: and Distribution: appear again after %description. At that point they will be treated as part of the package description text (not header tags), which is likely unintended and duplicates the header metadata. Remove these lines or move any intended tag definitions into the header section.

Suggested change
Vendor: Microsoft Corporation
Distribution: Azure Linux

Copilot uses AI. Check for mistakes.

%prep
%setup -q -n %{name}-%{version} -c

%build

Check warning on line 28 in base/comps/go-md2man/go-md2man.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

No %check section; Go packages should run unit tests (and go_vendor_license_check when vendored). (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/Golang/)
export GOPATH=%{OUR_GOPATH}
export GOCACHE=%{OUR_GOPATH}/.cache
export CGO_ENABLED=0
export GO111MODULE=on

cd %{_topdir}/BUILD/%{name}-%{version}/go-md2man-%{version}
go build -mod vendor -o go-md2man

%install
mkdir -p "%{buildroot}%{_bindir}"
cp -aT go-md2man-%{version}/go-md2man %{buildroot}%{_bindir}/go-md2man

# copy legal files
mkdir -p %{buildroot}%{_docdir}/%{name}-%{version}
cp go-md2man-%{version}/LICENSE.md %{buildroot}%{_docdir}/%{name}-%{version}/LICENSE.md
Comment on lines +26 to +43
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The %setup ... -c + absolute cd %{_topdir}/BUILD/... approach creates a nested source dir and hard-codes build paths, making the spec harder to maintain and more brittle across build environments. Prefer a single top-level source dir and relative/standard macros (e.g., %{_builddir}) so subsequent sections don’t depend on the nested layout.

Suggested change
%setup -q -n %{name}-%{version} -c
%build
export GOPATH=%{OUR_GOPATH}
export GOCACHE=%{OUR_GOPATH}/.cache
export CGO_ENABLED=0
export GO111MODULE=on
cd %{_topdir}/BUILD/%{name}-%{version}/go-md2man-%{version}
go build -mod vendor -o go-md2man
%install
mkdir -p "%{buildroot}%{_bindir}"
cp -aT go-md2man-%{version}/go-md2man %{buildroot}%{_bindir}/go-md2man
# copy legal files
mkdir -p %{buildroot}%{_docdir}/%{name}-%{version}
cp go-md2man-%{version}/LICENSE.md %{buildroot}%{_docdir}/%{name}-%{version}/LICENSE.md
%setup -q -n go-md2man-%{version}
%build
cd go-md2man-%{version}
export GOPATH=%{OUR_GOPATH}
export GOCACHE=%{OUR_GOPATH}/.cache
export CGO_ENABLED=0
export GO111MODULE=on
go build -mod vendor -o go-md2man
%install
cd go-md2man-%{version}
mkdir -p "%{buildroot}%{_bindir}"
cp -aT go-md2man %{buildroot}%{_bindir}/go-md2man
# copy legal files
mkdir -p %{buildroot}%{_docdir}/%{name}-%{version}
cp LICENSE.md %{buildroot}%{_docdir}/%{name}-%{version}/LICENSE.md

Copilot uses AI. Check for mistakes.

%files
%license %{_docdir}/%{name}-%{version}/LICENSE.md
%{_bindir}/go-md2man

%changelog

Check notice on line 49 in base/comps/go-md2man/go-md2man.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Consider using %autochangelog instead of manual changelog entries. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs)
* Fri Oct 27 2023 CBL-Mariner Servicing Account <cblmargh@microsoft.com> - 2.0.2-1
- Auto-upgrade to 2.0.2 - Azure Linux 3.0 - package upgrades

* Mon Oct 16 2023 CBL-Mariner Servicing Account <cblmargh@microsoft.com> - 2.0.1-21
- Bump release to rebuild with go 1.20.10

* Tue Oct 10 2023 Dan Streetman <ddstreet@ieee.org> - 2.0.1-20
- Bump release to rebuild with updated version of Go.

* Mon Aug 07 2023 CBL-Mariner Servicing Account <cblmargh@microsoft.com> - 2.0.1-19
- Bump release to rebuild with go 1.19.12

* Thu Jul 13 2023 CBL-Mariner Servicing Account <cblmargh@microsoft.com> - 2.0.1-18
- Bump release to rebuild with go 1.19.11

* Thu Jun 15 2023 CBL-Mariner Servicing Account <cblmargh@microsoft.com> - 2.0.1-17
- Bump release to rebuild with go 1.19.10

* Wed Apr 05 2023 CBL-Mariner Servicing Account <cblmargh@microsoft.com> - 2.0.1-16
- Bump release to rebuild with go 1.19.8

* Tue Mar 28 2023 CBL-Mariner Servicing Account <cblmargh@microsoft.com> - 2.0.1-15
- Bump release to rebuild with go 1.19.7

* Wed Mar 15 2023 CBL-Mariner Servicing Account <cblmargh@microsoft.com> - 2.0.1-14
- Bump release to rebuild with go 1.19.6

* Fri Feb 03 2023 CBL-Mariner Servicing Account <cblmargh@microsoft.com> - 2.0.1-13
- Bump release to rebuild with go 1.19.5

* Wed Jan 18 2023 CBL-Mariner Servicing Account <cblmargh@microsoft.com> - 2.0.1-12
- Bump release to rebuild with go 1.19.4

* Fri Dec 16 2022 Daniel McIlvaney <damcilva@microsoft.com> - 2.0.1-11
- Bump release to rebuild with go 1.18.8 with patch for CVE-2022-41717

* Tue Nov 01 2022 Olivia Crain <oliviacrain@microsoft.com> - 2.0.1-10
- Bump release to rebuild with go 1.18.8

* Mon Aug 22 2022 Olivia Crain <oliviacrain@microsoft.com> - 2.0.1-9
- Bump release to rebuild against Go 1.18.5

* Tue Jun 14 2022 Muhammad Falak <mwani@microsoft.com> - 2.0.1-8
- Bump release to rebuild with golang 1.18.3

* Fri Mar 04 2022 Andrew Phelps <anphel@microsoft.com> 2.0.1-1
- Update to version 2.0.1
- License verified

* Fri Jun 18 2021 Henry Li <lihl@microsoft.com> 2.0.0-7
- Provides go-go-md2man.
- Fix linting errors.

* Tue Jun 08 2021 Henry Beberman <henry.beberman@microsoft.com> 2.0.0-6
- Increment release to force republishing using golang 1.15.13.

* Thu Dec 10 2020 Andrew Phelps <anphel@microsoft.com> 2.0.0-5
- Increment release to force republishing using golang 1.15.

* Wed May 20 2020 Joe Schmitt <joschmit@microsoft.com> 2.0.0-4
- Remove reliance on existing GOPATH environment variable.

* Sat May 09 2020 Nick Samson <nisamson@microsoft.com> 2.0.0-3
- Added %%license line automatically

* Fri May 01 2020 Emre Girgin <mrgirgin@microsoft.com> 2.0.0-2
- Renaming go to golang

* Fri Apr 03 2020 Mohan Datla <mdatla@microsoft.com> 2.0.0-1
- Original version for CBL-Mariner.
Loading