Skip to content

fix: [#4907] adaptive-expression does not work in the browser anymore #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: [#4907] adaptive-expression does not work in the browser anymore #4909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dff3598
Fix browser build for adaptive-expressions
ceciliaavila Nov 11, 2025
92f9dab
Minify package with terser
ceciliaavila Nov 11, 2025
c4004c6
Add terser as devDependency
ceciliaavila Nov 12, 2025
4c3d845
Allow minify option override in tsup config.
ceciliaavila Nov 12, 2025
cfc4caf
Ignore terser in depcheck validations
ceciliaavila Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions libraries/adaptive-expressions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,35 +31,37 @@
"@types/atob-lite": "^2.0.2",
"@types/btoa-lite": "^1.0.2",
"@types/lru-cache": "^5.1.1",
"@types/xmldom": "^0.1.34",
"@xmldom/xmldom": "^0.8.6",
"antlr4ts": "0.5.0-alpha.4",
"atob-lite": "^2.0.0",
"big-integer": "^1.6.52",
"@types/xmldom": "^0.1.34",
"btoa-lite": "^1.0.0",
"d3-format": "^3.1.0",
"dayjs": "^1.11.13",
"fast-xml-parser": "^4.4.1",
"jspath": "^0.4.0",
"lodash": "^4.17.21",
"lru-cache": "^5.1.1",
"uuid": "^10.0.0",
"fast-xml-parser": "^4.4.1",
"@xmldom/xmldom": "^0.8.6",
"xpath": "^0.0.34"
},
"devDependencies": {
"@types/jspath": "^0.4.2",
"antlr4ts-cli": "0.5.0-alpha.4",
"terser": "^5.44.1",
"typescript": "~4.8"
},
"scripts": {
"build": "npm-run-all build:src build:tests build:browser",
"build:src": "tsc -b",
"build:tests": "tsc -p tests/tsconfig.json",
"build:browser": "npm-run-all build:browser:clean build:browser:run",
"build:browser": "npm-run-all build:browser:clean build:browser:run build:browser:min",
"build:browser:clean": "rimraf --glob lib/browser.*",
"build:browser:run": "tsup --config ../../tsup/browser.config.ts",
"build:browser:run": "tsup --no-minify --config ../../tsup/browser.config.ts",
"build:browser:min": "terser lib/browser.js --compress --output lib/browser.js",
"clean": "rimraf lib vendors tsconfig.tsbuildinfo",
"depcheck": "depcheck --config ../../.depcheckrc --ignores @types/xmldom,d3-format,sinon",
"depcheck": "depcheck --config ../../.depcheckrc --ignores @types/xmldom,d3-format,sinon,terser",
"build-docs": "typedoc --theme markdown --entryPoint adaptive-expressions --excludePrivate --includeDeclarations --ignoreCompilerErrors --module amd --out ..\\..\\doc\\adaptive-expressions .\\lib\\index.d.ts --hideGenerator --name \"Bot Builder SDK - Expression\" --readme none",
"test": "yarn build && mocha tests --timeout 60000",
"test:compat": "api-extractor run --verbose",
Expand Down
7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@
"@types/node": "^18.19.123",
"@types/sinon": "^17.0.3",
"applicationinsights": "^2.9.6",
"assert": "^2.1.0",
"depcheck": "^1.4.7",
"esbuild-plugin-polyfill-node": "^0.3.0",
"https-browserify": "^1.0.0",
"eslint": "^9.15.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-import": "^2.31.0",
Expand All @@ -104,8 +104,9 @@
"eslint-plugin-mocha": "^10.5.0",
"eslint-plugin-prettier": "^5.2.1",
"eslint-plugin-security": "^3.0.1",
"mocha-junit-reporter": "^2.2.1",
"https-browserify": "^1.0.0",
"mocha": "^10.7.3",
"mocha-junit-reporter": "^2.2.1",
"npm-run-all": "^4.1.5",
"nyc": "^17.0.0",
"prettier": "^3.3.3",
Expand All @@ -117,9 +118,9 @@
"stream-http": "^3.2.0",
"ts-node": "^10.9.2",
"tsup": "^8.2.4",
"typedoc": "^0.26.7",
"typedoc-plugin-external-module-name": "^4.0.6",
"typedoc-plugin-markdown": "^4.2.7",
"typedoc": "^0.26.7",
"typescript": "~4.8",
"typescript-eslint": "^8.15.0",
"webpack-dev-server": "^5.2.1",
Expand Down
4 changes: 3 additions & 1 deletion tsup/browser.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default defineConfig((options) => {
format: ['cjs'],
bundle: true,
sourcemap: true,
minify: true,
minify: options.minify !== false,
treeshake: true,
splitting: false,
external,
Expand All @@ -40,6 +40,7 @@ export default defineConfig((options) => {
global: 'globalThis',
};
options.alias = {
assert: 'assert',
crypto: resolve(__dirname, 'crypto-shim.js'),
http: 'stream-http',
https: 'https-browserify',
Expand All @@ -52,6 +53,7 @@ export default defineConfig((options) => {
esbuildPlugins: [
polyfillNode({
polyfills: {
assert: false,
buffer: false,
child_process: true,
crypto: false,
Expand Down
Loading
Loading