Conversation
lalitb
requested review from
bliptec,
kindbe,
maxgolov,
mkoscumb,
reyang and
sid-dahiya
as code owners
…ry into v4-refactor
This reverts commit ad8dafd.
mkoscumb
reviewed
Mar 9, 2023
| @@ -731,7 +731,7 @@ namespace MAT_NS_BEGIN | |||
| static ILogManager* GetInstance() noexcept | |||
Contributor
There was a problem hiding this comment.
This probably needs to go as well
Contributor
There was a problem hiding this comment.
Really all the static methods
Contributor
Author
There was a problem hiding this comment.
Yes, I am trying to see if we can make LogManager as instance of LogManagerBase instead of global static, and then make all these methods as non-static. Though LogConfiguration is still a concern here, as it is difficult to create deep copy of it (as it can contain void * as the config value).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ongoing PR, not yet for review.
Included changes