Skip to content

Clean up lib\include\mat\json.hpp and update Private Modules Commit ID.#1330

Open
mkoscumb wants to merge 4 commits intomainfrom
mkoscumb/MoveJsonHppStage3
Open

Clean up lib\include\mat\json.hpp and update Private Modules Commit ID.#1330
mkoscumb wants to merge 4 commits intomainfrom
mkoscumb/MoveJsonHppStage3

Conversation

@mkoscumb
Copy link
Contributor

@mkoscumb mkoscumb commented Feb 11, 2025

Beyond being good dependency hygiene, this will also allow adopters which have their own copy of json.hpp to more easily use that when integrating the 1DS C++ SDK (via include path modification)

This work will be broken down into three PRs.

  1. This PR Copy json.hpp from lib\include\mat => nlohmann\ update include paths accordingly. - Move json.hpp to a peer folder of other third-party dependencies - Stage 1 #1325
  2. Update include paths in the private modules repo.
  3. #This PR# Remove lib\include\mat\json.hpp and update the private modules repo commit to the result of Stage 2.

@mkoscumb mkoscumb requested a review from a team as a code owner February 11, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants