This repository was archived by the owner on Apr 6, 2026. It is now read-only.
Reimplemented Dev Center - Dev Box Definitions using AzAPI#17
Merged
arnaudlh merged 10 commits intomicrosoft:mainfrom Jun 17, 2025
Merged
Reimplemented Dev Center - Dev Box Definitions using AzAPI#17arnaudlh merged 10 commits intomicrosoft:mainfrom
arnaudlh merged 10 commits intomicrosoft:mainfrom
Conversation
added 3 commits
May 30, 2025 13:56
- Added .vscode/mcp.json to configure Terraform and Azure MCP servers. - Updated .gitignore to include .vscode/mcp.json for version control.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reimplements the Dev Center DevBox Definition module to use the AzAPI provider (v2.4.0) and adds richer variable validation, image–reference preprocessing, expanded outputs, and updated documentation/examples. It also moves DevBox prompts into .github/prompts, adds an MCP config in .vscode/mcp.json, and supplies a commit‐message snippet for Copilot.
- Swapped
azurerm_dev_center_dev_box_definitionforazapi_resourceand addeddata.azapi_client_config+ locals to resolve subscription IDs. - Enhanced
variables.tfwith strong typing and multiplevalidationblocks. - Expanded outputs in
output.tfand updated module README/examples to reflect new inputs.
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/dev_center_dev_box_definition/variables.tf | Added object‐typing and validation rules for inputs |
| modules/dev_center_dev_box_definition/module.tf | Replaced resource with azapi_resource, added locals logic |
| modules/dev_center_dev_box_definition/README.md | Updated usage examples; documented new features |
| .vscode/mcp.json | Added VS Code MCP server configuration |
| .github/prompt-snippets/commit-message.md | Added commit‐message instructions for Copilot |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
arnaudlh
suggested changes
Jun 16, 2025
Collaborator
arnaudlh
left a comment
arnaudlh
left a comment
There was a problem hiding this comment.
Was there a reason for schema validation to be disabled?
| response_export_values = ["properties.provisioningState", "properties.imageReference", "properties.sku"] | ||
|
|
||
| # Disable schema validation as the provider validation is overly strict for preview APIs | ||
| schema_validation_enabled = false |
Collaborator
There was a problem hiding this comment.
Suggested change
| schema_validation_enabled = false | |
| schema_validation_enabled = true |
| } | ||
| } | ||
| # Linux development environment | ||
| ubuntu_development = { |
Collaborator
There was a problem hiding this comment.
Maybe comment out while preview?
arnaudlh
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplemented Devbox definitions using azapi. In addition, made the following improvements for copilot prompts:
.github/prompts/devbox-tf.prompt.md. To trigger, type/devbox-tf <message>.vscode/mcp.jsonfor the Azure and Terraform MCP Servers. (NOTE: this is not runnable in the dev container yet)Also added
.github/prompt-snippets/commit-message.md. To use, add the following in vscode settings