Adding Devbox pools and schedules

.github/copilot-instructions.md

@@ -1,3 +1,11 @@
+## When writing or updating Terraform code
+Use the instructions [here](./github/instructions/devbox-tf.instructions.md) for writing/updating Terraform code.
+
+## When updating code
+Document the changes made in the [CHANGELOG.md](CHANGELOG.md) file, including:
+- A brief description of the change.
+- If it is a bug fix, feature, or improvement.
+- Include assessment if this is a breaking change or not.
 ## MCP Server Instructions
 If the respective MCP server exists, follow these instructions:
 - Terraform MCP Server: provides seamless integration with Terraform Registry APIs, enabling advanced automation and interaction capabilities for Infrastructure as Code (IaC) development.

.github/instructions/devbox-tf.instructions.md

@@ -0,0 +1,311 @@
+# Devfactory Project - Terraform Implementation Guidelines
+
+## Quick Reference Summary
+
+- **Provider:** AzAPI v2.4.0 only
+- **Run Location:** Always from project root
+- **Sensitive Data:** Never hardcode credentials or subscription IDs
+- **Module Verification:** Always check resource arguments against latest provider docs
+- **Variable Typing:** Use strong types, descriptions, and constraints
+- **Examples:** Every resource/module must have an example in `/examples/`
+- **Validation:** Run `terraform fmt` and `terraform validate` before commit
+
+---
+
+## DO
+- Use only AzAPI provider version 2.4.0
+- Place all resource modules in `/modules/` and examples in `/examples/`
+- Use dynamic blocks for optional/flexible config
+- Use nested maps and strongly-typed objects for variables
+- Use `locals` for preprocessing and complex parameter objects
+- Use `try()` for error handling and parameter fallbacks
+- Merge tags (resource-specific + global)
+- Use `azurecaf_name` for naming conventions
+- Add input validation in `variables.tf`
+- Add a working example for every resource/module
+- Update module README.md with usage and examples
+- Reference provider docs for every resource: https://registry.terraform.io/providers/Azure/azapi/2.4.0/docs/resources/<resource>
+- Use the Azure MCP server to find the latest API version, detailed schema, and attributes for each resource implemented.
+
+## DO NOT
+- Do not embed subscription IDs or credentials in code/config
+- Do not use untyped or weakly-typed variables
+- Do not skip example creation for new/changed resources
+- Do not commit without running `terraform fmt` and `terraform validate`
+- Do not use provider versions other than 2.4.0
+
+---
+
+## Repository Structure
+- `/modules/`: Resource-specific modules (storage, networking, compute, etc.)
+- `/examples/`: Example implementations/configurations for each module
+- `/docs/`: Project documentation and conventions
+
+---
+
+## Key Module Patterns
+- Each Azure resource type in its own module folder
+- Use dynamic blocks for optional/flexible config
+- Input variables: nested maps, strongly-typed objects
+
+---
+
+## Code Conventions
+- Each module: `module.tf`, `variables.tf`, `output.tf`
+- Use `locals` for preprocessing/complex objects
+- Use `try()` for optional/defaulted params
+- Merge tags (resource + global)
+- Use `azurecaf_name` for naming
+
+---
+
+## Common Patterns
+
+**Resource Creation:**
+```hcl
+resource "azurecaf_name" "this" {
+  name          = var.name
+  resource_type = "general"
+  prefixes      = var.global_settings.prefixes
+  random_length = var.global_settings.random_length
+  clean_input   = true
+  passthrough   = var.global_settings.passthrough
+  use_slug      = var.global_settings.use_slug
+}
+
+resource "azapi_resource" "this" {
+  name        = azurecaf_name.this.result
+  location    = var.location
+  parent_id   = var.parent_id
+  type        = var.resource_type
+  api_version = var.api_version
+  tags        = local.tags
+  # Resource-specific properties
+}
+```
+
+**Variable Structure and Typing:**
+```hcl
+variable "resource" {
+  description = "Configuration object for the resource"
+  type = object({
+    name        = string
+    description = optional(string)
+    location    = optional(string)
+    tags        = optional(map(string))
+    # Resource-specific properties
+    sku = object({
+      name     = string
+      tier     = string
+      capacity = optional(number)
+    })
+    security = optional(object({
+      enable_rbac = optional(bool, false)
+      network_acls = optional(list(object({
+        default_action = string
+        bypass         = string
+        ip_rules       = optional(list(string))
+      })))
+    }))
+  })
+}
+
+variable "global_settings" {
+  description = "Global settings object for naming conventions and standard parameters"
+  type = object({
+    prefixes      = list(string)
+    random_length = number
+    passthrough   = bool
+    use_slug      = bool
+    environment   = string
+    regions       = map(string)
+  })
+}
+```
+
+**Module Integration with Strong Typing:**
+```hcl
+module "resource" {
+  source   = "./modules/resource"
+  for_each = try(var.settings.resources, {})
+  global_settings     = var.global_settings
+  settings            = each.value
+  resource_group_name = var.resource_group_name
+  location            = try(each.value.location, var.location)
+  tags                = try(each.value.tags, {})
+  depends_on = [
+    module.resource_groups
+  ]
+}
+```
+
+**Variable Validation:**
+```hcl
+variable "environment_type" {
+  description = "The type of environment to deploy (dev, test, prod)"
+  type        = string
+  validation {
+    condition     = contains(["dev", "test", "prod"], var.environment_type)
+    error_message = "Environment type must be one of: dev, test, prod."
+  }
+}
+
+variable "allowed_ip_ranges" {
+  description = "List of allowed IP ranges in CIDR format"
+  type        = list(string)
+  validation {
+    condition     = alltrue([for ip in var.allowed_ip_ranges : can(cidrhost(ip, 0))])
+    error_message = "All elements must be valid CIDR notation IP addresses."
+  }
+}
+```
+
+**Dynamic Blocks Implementation:**
+```hcl
+resource "azurerm_key_vault" "kv" {
+  # ... other properties ...
+  dynamic "network_acls" {
+    for_each = try(var.settings.network, null) != null ? [var.settings.network] : []
+    content {
+      default_action             = network_acls.value.default_action
+      bypass                     = network_acls.value.bypass
+      ip_rules                   = try(network_acls.value.ip_rules, [])
+      virtual_network_subnet_ids = try(network_acls.value.subnets, [])
+    }
+  }
+}
+```
+
+---
+
+## Example Patterns
+- Add an example for each feature under `/examples/_feature_name/simple_case/configuration.tfvars`
+- Include a `global_settings` block for naming
+- Define resources in nested map structure
+- Link dependent resources using parent key reference
+
+---
+
+## Execution Instructions
+- Run from root:
+  ```bash
+  terraform init
+  terraform plan -var-file=examples/_feature_name/simple_case/configuration.tfvars
+  terraform apply -var-file=examples/_feature_name/simple_case/configuration.tfvars
+  ```
+- Destroy resources:
+  ```bash
+  terraform destroy -var-file=examples/_feature_name/simple_case/configuration.tfvars
+  ```
+- Set authentication via environment variables (never in code):
+  ```bash
+  export ARM_SUBSCRIPTION_ID=$(az account show --query id -o tsv)
+  export ARM_CLIENT_ID="your-client-id"
+  export ARM_CLIENT_SECRET="your-client-secret"
+  export ARM_TENANT_ID="your-tenant-id"
+  ```
+
+---
+
+## Testing & Validation
+- Add input validation in `variables.tf`
+- Add a working example in `/examples/`
+- Update module README.md with usage and examples
+- Run `terraform validate` and `terraform fmt` before commit
+
+---
+
+## Common Helper Patterns
+- `try(var.settings.property, default_value)` for fallbacks
+- `lookup(map, key, default)` for map access
+- `can(tostring(var.something))` for conditional evaluation
+- `for_each = toset(var.subnet_names)` for multiple resources
+- `coalesce(var.custom_name, local.default_name)` for first non-null value
+
+---
+
+## Azure API Property Naming and Data Type Conventions
+
+### DevCenter API Specifics (API Version 2025-04-01-preview)
+When working with Azure DevCenter resources, be aware of these critical naming and data type requirements:
+
+**Property Naming Convention:**
+- Azure DevCenter API requires camelCase property names in the request body
+- Terraform variables use snake_case for consistency
+- Always map snake_case variable names to camelCase API properties
+
+**Common Property Mappings:**
+```hcl
+# Variable (snake_case) → API Property (camelCase)
+install_azure_monitor_agent_enable_installation → installAzureMonitorAgentEnableStatus
+microsoft_hosted_network_enable_status → microsoftHostedNetworkEnableStatus
+catalog_item_sync_enable_status → catalogItemSyncEnableStatus
+```
+
+**Data Type Requirements:**
+- Many DevCenter "enable" properties expect string values, not booleans
+- Use `"Enabled"` or `"Disabled"` instead of `true`/`false`
+- Always verify expected data types in Azure API documentation
+
+**Example Implementation:**
+```hcl
+# Variable definition (snake_case, string type)
+variable "dev_box_provisioning_settings" {
+  type = object({
+    install_azure_monitor_agent_enable_installation = optional(string, "Enabled")
+  })
+}
+
+# API body mapping (camelCase)
+body = {
+  properties = {
+    devBoxProvisioningSettings = {
+      installAzureMonitorAgentEnableStatus = try(var.settings.dev_box_provisioning_settings.install_azure_monitor_agent_enable_installation, "Enabled")
+    }
+  }
+}
+```
+
+**Validation Approach:**
+- Always run `terraform plan` to validate API compatibility
+- Check Azure API documentation for exact property names and types
+- Use Azure MCP server tools to verify latest API schemas
+- Test with actual API calls when implementing new resource properties
+- Also test changes with TFLint, `terraform fmt` and `terraform validate`
+
+---
+
+## Security Best Practices
+- Use `sensitive = true` for secret variables
+- Never hardcode credentials
+- Use least privilege IAM roles
+- Use NSGs and private endpoints
+- Store state files securely with locking
+- Use key vaults for sensitive values
+
+---
+
+## Documentation Reference
+- See README.md in each module
+- See `/examples/` for implementation
+- See `docs/conventions.md` for standards
+- See `docs/module_guide.md` for module development
+- Always verify resource arguments at: https://registry.terraform.io/providers/Azure/azapi/2.4.0/docs/resources/<resource>
+
+---
+
+## AI Assistant Prompt Guidance
+- When asked to generate Terraform code, always:
+  - Use AzAPI provider v2.4.0
+  - Use strong typing and validation for variables
+  - Add an example in `/examples/`
+  - Reference provider documentation for all arguments
+  - Never include credentials or subscription IDs in code
+  - Use dynamic blocks and locals as shown above
+  - Follow naming conventions with `azurecaf_name`
+  - Add input validation and documentation
+  - Use only patterns and helpers listed above
+
+---
+
+This dev container includes the Azure CLI, GitHub CLI, Terraform CLI, TFLint, and Terragrunt pre-installed and available on the PATH, along with the Terraform and Azure extensions for development.

.gitignore

@@ -6,6 +6,9 @@
 # Environment Variables
 .env
 
+# User generated configuration files (the configuration directory)
+/configurations
+
 # User-specific files
 *.rsuser
 *.suo

.vscode/mcp.json

@@ -19,6 +19,10 @@
                 "server",
                 "start"
             ]
+        },
+        "github": {
+             "type": "http",
+            "url": "https://api.githubcopilot.com/mcp/"
         }
     }
 }

CHANGES_SUMMARY.md

@@ -4,6 +4,49 @@
 
 This document summarizes the updates made to the Azure DevCenter module to implement the 2025-04-01-preview API version and fix the identity block placement.
 
+## Latest Changes (June 19, 2025)
+
+### Merge Conflict Resolution
+- **Fixed**: Resolved merge conflicts in PR #24 (devboxpools branch)
+- **Conflict Location**: `tests/run_tests.sh` - between dynamic test discovery and hardcoded test list
+- **Resolution**: Preserved enhanced dynamic test discovery functionality while merging upstream changes
+- **Merged Changes**: Updated from upstream main:
+  - `.devcontainer/devcontainer.json` - DevContainer configuration updates
+  - `.vscode/mcp.json` - MCP server configuration
+  - `README.md` - Documentation improvements
+  - `docs/getting_started.md` - Getting started guide updates
+- **Type**: Bug fix and merge resolution
+- **Breaking Change**: No
+
+### TFLint Compliance Fixes
+- **Fixed**: Added missing `required_version = ">= 1.9.0"` to Terraform blocks
+  - `modules/dev_center_project_pool/module.tf`
+  - `modules/dev_center_project_pool_schedule/module.tf`
+- **Fixed**: Added TFLint ignore comment for unused but documented variable
+  - `modules/dev_center_project_pool/variables.tf` - `resource_group_id` variable
+- **Result**: All modules now pass TFLint validation without warnings
+- **Type**: Code quality improvement
+- **Breaking Change**: No
+
+### Test Runner Update
+- **Fixed**: Updated `tests/run_tests.sh` to include all missing test directories
+- **Enhanced**: Made test discovery dynamic instead of hardcoded
+  - Automatically discovers unit test directories in `tests/unit/`
+  - Automatically discovers integration test directories in `tests/integration/`
+  - Validates directories contain test files (*.tftest.hcl or *.tf)
+  - Shows discovered test directories before execution
+- **Fixed**: Added proper root configuration initialization
+  - Initializes root Terraform configuration before running tests
+  - Properly handles module dependencies for tests that reference root configuration
+  - Cleans and re-initializes test directories when needed
+- **Added**: Missing unit test directories:
+  - `dev_center_project_pool`
+  - `dev_center_project_pool_schedule`
+  - `key_vault`
+- **Result**: All 9 test suites now pass (41 individual test cases)
+- **Type**: Improvement and bug fix
+- **Breaking Change**: No
+
 ## Issues Addressed
 
 1. **API Version Update**: Updated from `2025-02-01` to `2025-04-01-preview`