Skip to content

Change log level from Warning to Information for normal JSON parsing failures #5218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Change log level from Warning to Information for normal JSON parsing failures #5218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2254834
Initial plan
Copilot Nov 1, 2025
edf033f
Change log level from Warning to Information for normal operations
Copilot Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirDataStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,16 +956,16 @@ private string GetJsonValue(string json, string propName, bool isExisting)
var startIndex = json.IndexOf($"\"{propName}\":\"", StringComparison.Ordinal);
if (startIndex == -1)
{
// I think this should be a warning because it happens every time a resource is deleted. Maybe even info.
_logger.LogWarning($"Cannot parse {propName} value from {(isExisting ? "existing" : "input")}");
// This happens during normal operations (e.g., resource deletion) and is not an error condition.
_logger.LogInformation($"Cannot parse {propName} value from {(isExisting ? "existing" : "input")}");
return string.Empty;
}

startIndex = startIndex + propName.Length + 4;
var endIndex = json.IndexOf('"', startIndex);
if (endIndex == -1)
{
_logger.LogWarning($"Cannot parse {propName} value from {(isExisting ? "existing" : "input")}");
_logger.LogInformation($"Cannot parse {propName} value from {(isExisting ? "existing" : "input")}");
return string.Empty;
}

Expand Down