-
Notifications
You must be signed in to change notification settings - Fork 574
Added multiple id read using stored proc. #5278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
52ea105
Added multiple id read using stored proc.
PTaladay 4f5a503
Updated tests nased on parsing of resource type.
PTaladay 2e86002
Removed unneeded tests.
PTaladay 001082a
Merge remote-tracking branch 'origin/main' into personal/patalada/179104
PTaladay 0fe596d
Updated logic for parsing expression and grabbing the id list when mu…
PTaladay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
122 changes: 0 additions & 122 deletions
122
...ealth.Fhir.SqlServer.UnitTests/Features/Search/SqlServerSearchServiceOptimizationTests.cs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning
Copilot Autofix
AI 3 days ago
In general, to fix a “missing Dispose call” for a local
IDisposable, wrap the creation and use of the object in ausingstatement (orusingdeclaration in newer C#), so thatDisposeis called automatically when execution leaves theusingscope, even if an exception is thrown.For this specific case in
SqlServerSearchService.cs, the best fix is to wrap theDataTable’s lifetime in ausingblock. That means replacing the standalonevar resourceKeysTable = new DataTable();and subsequent code that usesresourceKeysTablewith ausing (var resourceKeysTable = new DataTable()) { ... }block, moving all uses ofresourceKeysTable(column definitions, row population, and parameter creation) inside that block. This keeps behavior the same: theDataTableexists for the duration of building the TVP parameter and callingAddWithValue, and then is disposed when the block exits. No additional imports or helper methods are needed, sinceDataTableandIDisposableare already available via existingusingdirectives.Concretely, within
src/Microsoft.Health.Fhir.SqlServer/Features/Search/SqlServerSearchService.cs, in the showntryblock around line 990, introduce ausingblock starting at line 993, move lines 994–1002 and 1005–1009 inside that block, and adjust indentation accordingly. No other code outside that local section needs to change.