Skip to content

Conversation

@paorodma-ms
Copy link
Contributor

Hard deletes inside a transaction bundle should be allowed, but not conditional deletes.

Description

Describe the changes in this PR.

Related issues

Addresses issue.

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@paorodma-ms paorodma-ms added this to the FY26\Q2\2Wk\2Wk13 milestone Dec 24, 2025
@paorodma-ms paorodma-ms requested a review from a team as a code owner December 24, 2025 19:04
@paorodma-ms paorodma-ms added Bug Bug bug bug. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Schema Version unchanged labels Dec 24, 2025
// Conditional Delete operation is not currently supported.
// However, hard deletes (DELETE {type}/{id}?_hardDelete=true) are allowed.
// Conditional deletes have the pattern: DELETE {type}?{query} (no resource ID).
if (requestMethod == HTTPVerb.DELETE && requestUrl.Contains('?', StringComparison.Ordinal))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for hard delete in a bundle?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@paorodma-ms paorodma-ms merged commit 40f6158 into main Jan 7, 2026
60 of 61 checks passed
@paorodma-ms paorodma-ms deleted the personal/paolaro/bug18986 branch January 7, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. Schema Version unchanged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants