Merged
Conversation
…nto a separate folder/subspec
mischreiber
approved these changes
Jun 21, 2024
Collaborator
mischreiber
left a comment
There was a problem hiding this comment.
Looks good overall! I'm debating about the name TableViewListShared, but I also don't have a better idea.
alexanderboswell
approved these changes
Jun 21, 2024
joannaquu
reviewed
Jun 21, 2024
Saadnajmi
reviewed
Jun 21, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Continuation of #1939
Binary change
Not adding/removing any source code, so I don't think this PR should impact binary size - but if there's a reason to run this let me know
(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)
Verification
pod lib lintpasses. Unfortunately each run of this seemed like it took about 20 minutes. If there's a faster way to validate podspec changes in fluentui-apple let me know!Microsoft Reviewers: Open in CodeFlow