-
Notifications
You must be signed in to change notification settings - Fork 178
[TwoLineTitleViewDemoController] Fix demo crash for iOS 26.* and macCatalyst 26.* #2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
rip our xcuitests should have caught this... |
joannaquu
approved these changes
Jan 22, 2026
Contributor
oh wait two line title view doesn't have one. can we bundle one in with your change? should just be able to copy paste
|
mischreiber
reviewed
Jan 22, 2026
Demos/FluentUIDemo_iOS/FluentUI.Demo/Demos/TwoLineTitleViewDemoController.swift
Show resolved
Hide resolved
mischreiber
approved these changes
Jan 22, 2026
joannaquu
reviewed
Jan 22, 2026
joannaquu
approved these changes
Jan 22, 2026
joannaquu
approved these changes
Jan 23, 2026
joannaquu
reviewed
Jan 27, 2026
joannaquu
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
The
TwoLineTitleViewDemoControllercrashes on open due to apreconditionFailure"A title image and a subtitle must be provided whenisTitleImageLeadingForTitleAndSubtitleis set to true." in theTwoLineTitleView.setup(...)function.Add an
availablecheck in calls themakeExampleNavigationItemso that we set theUINavigationItem.subtitlefield for devices running an OS >= 26 and thefluentConfiguration.subtitlefor an OS < 26.Add XCUITest case for this demo controller.
Binary change
(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)
Verification
I validated that the demo controller no longer crashes on open and that the subtitles appear as expected.
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow