[MSFNotification] Enable support for bottomPresentationPadding token #2241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
This change enables the
MSFNotificationto respect and respond to changes of thebottomPresentationPaddingtoken. Previously, the control did not respect this token.Changes:
tokenSetfor updates. CallupdateBottomPresentationPaddingwhen an update occurs.updateBottomPresentationPaddingwhich updates the constant on the bottom constraintconstraintWhenHiddenandconstraintWhenShownproperties fromNSLayoutConstraint!toNSLayoutConstraint?and make needed updates to support this change. We should avoid using implicitly unwrapped properties at all costs.Binary change
(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)
Verification
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow