chore: migrate to node 22, nx 22.3 and resolve node native support issues with jest configs and typescript#604
Open
Hotell wants to merge 11 commits intomicrosoft:mainfrom
Open
chore: migrate to node 22, nx 22.3 and resolve node native support issues with jest configs and typescript#604Hotell wants to merge 11 commits intomicrosoft:mainfrom
Hotell wants to merge 11 commits intomicrosoft:mainfrom
Conversation
…t work with old @nx/jest executor with jest 30 and node 22+ which added native TypeScript support
Hotell
force-pushed
the
tools/bump-nx-node-22
branch
from
64b111d to
35be927
Compare
Hotell
changed the title
… make it work with old @nx/jest executor with jest 30 and node 22+ which added native TypeScript support
… DX and make it work with old @nx/jest executor with jest 30 and node 22+ which added native TypeScript support
Hotell
changed the title
Hotell
requested review from
a team,
dmytrokirpa,
hectorjjb,
mainframev,
marcosmoura and
spmonahan
as code owners
Hotell
commented
Jan 15, 2026
|
|
||
| export default async function (tree: Tree, options: LibraryGeneratorSchema) { | ||
| const { name, owner } = options; | ||
| const { name, owner, testEnvironment = 'jsdom' } = options; |
Contributor
Author
There was a problem hiding this comment.
this is default option when invoked via nx g / explicitly normalizing the logic
hectorjjb
approved these changes
Jan 15, 2026
Collaborator
hectorjjb
left a comment
hectorjjb
left a comment
There was a problem hiding this comment.
good for gamepad navigation 👍🏼
mainframev
approved these changes
Jan 16, 2026
dmytrokirpa
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Node.js version used in all CI workflows to 22, modernizes and standardizes Jest config files for React test apps, and improves configuration file exclude patterns. It also includes change files for multiple packages documenting the removal of Jest config from excludes.
Key changes include:
CI and Workflow Updates:
ci.yml,ci-change.yml,docs.yml) to ensure compatibility with the latest features and dependencies.Jest Config Update:
.tsto.mjsto avoid Node 22 native TypeScript support issues with@nx/jestexecutorWhile Nx addressed this issue with various migrations nrwl/nx#33657, nrwl/nx#33401 none of them felt "right" / didnt worked with
@nx/jestexecutor.jestrunner instead the executor, the most "straightforward" way was to migrate toesmformatworkspace plugin:
librarygenerator to use our own template instead@nx/jsone to accommodate our needsConfiguration Improvements:
beachball.config.jsto expand the exclude patterns for config files, including various Jest and ESLint config file extensions and addingtsconfig.spec.jsonto the exclude list.