Enable building of release candidate builds #788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing build-git-installers.yml workflow did not handle building release candidate builds correctly, mainly because it hasn't been exercised with a real release candidate build.
During the rc-stages of v2.51.0, various issues were uncovered:
v2.X.Y-rcN.vfs.W.Z
, but it was checking for a tag likev2.X.Y.vfs.W.Z.rcN
.-rc
part is replaced with.rc
and the leadingv
is dropped.. so a tag ofv2.51.0-rc0.vfs.0.0
will become2.51.0.rc0.vfs.0.0
. The macOS installed Makefile and scripts to create the Debian package did not correctly account for this, leading to build strings that were not consistent with those for Windows builds.With these changes, we can now successfully build release candidate versions. Tags must be of the form:
The resulting build version (output from
git --version
) looks like:Installer and package file names maintain the tag version format, for example:
See an example successful build here: https://github.com/microsoft/git/actions/runs/16830521090
VFS for Git recently learned to correctly parse these release candidate version strings here: microsoft/VFSForGit#1854