Strip __fragments field for non-query operations from fat/broad query

[ikjot-2605]

Strip __fragments field for non-query operations from fat/broad query

Subscriptions with fragment spreads were failing with errors about __fragments field not being found in the schema.

Root cause:

annotateFragmentReferenceTransform adds "... on Node { __fragments @client }" to all operations with fragment spreads. For queries, stripFragmentReferenceFieldSelectionTransform removes this from executionQueryDocument before output. For subscriptions/mutations, this stripping was being skipped.

Fix:

Move the stripping logic outside the "if (emitNarrowObservables)" block so it runs for all operation types, not just queries.

[alloy]

Thanks! Can you see what test coverage we have for this, presumably only for a query, and run the same test for subscription/mutation docs?

[ikjot-2605]

Thanks! Can you see what test coverage we have for this, presumably only for a query, and run the same test for subscription/mutation docs?

The tests for stripFragmentReferenceFieldSelectionTransform seem to be covering the main cases. We can still test if a subscription/mutation doc is passed to this helper - it must strip it off the __fragments field.

The tests for formatModule test that mutation and subscription operations "do(es) not add watch node queries for subscriptions". However it does not currently test that the execution document should be stripped off the __fragments @client field.

Added tests in both files. @alloy

[ikjot-2605]

@microsoft-github-policy-service agree

[alloy]

Looks great. Thanks!