Skip to content

Conversation

@Anteru
Copy link

@Anteru Anteru commented Jul 1, 2025

Allow i8 and u8 types, which are useful for pre-processing/post-processing data used in cooperative matrix/vector operations. Right now it's really ugly to unpack/pack via i32. This proposal enables i8 and u8 as native types in the shader core.

Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of notes remaining from me.

@Anteru
Copy link
Author

Anteru commented Aug 27, 2025

Can someone please re-run the CLA thing? It should be resolved on my end.

@damyanp
Copy link
Member

damyanp commented Aug 27, 2025

Can someone please re-run the CLA thing? It should be resolved on my end.

Please follow the instructions in the comment it posted.

@Anteru
Copy link
Author

Anteru commented Oct 1, 2025

CLA bot should be pleased now? I should have been added.

Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, CLA bot seems happy now.

Will need the header updated and the text formatted to 80 columns before we can accept this.

The comment around tying it to cooperative vectors can take or leave for now.

Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
@damyanp damyanp self-assigned this Oct 21, 2025
Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are still some unresolved comments that need to be addressed before we can merge this.

@damyanp damyanp removed their assignment Oct 22, 2025
@Anteru
Copy link
Author

Anteru commented Oct 22, 2025

Yep, I'll get on this in the coming days. Sorry for being a bit slow here :(

@damyanp
Copy link
Member

damyanp commented Oct 22, 2025

No worries, and no rush - I've just been looking through old PRs, and this one looked like it might be waiting for me to review new changes which is why I added the note on the current state.

Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks ready to merge and move on filing issues to track further feedback and work required on this proposal.

@llvm-beanz - as sponsor of this can you provide the 2nd review and shepherd this change in please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants