-
Notifications
You must be signed in to change notification settings - Fork 51
Add 8-bit integers back. #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of notes remaining from me.
|
Can someone please re-run the CLA thing? It should be resolved on my end. |
Please follow the instructions in the comment it posted. |
|
CLA bot should be pleased now? I should have been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, CLA bot seems happy now.
Will need the header updated and the text formatted to 80 columns before we can accept this.
The comment around tying it to cooperative vectors can take or leave for now.
Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are still some unresolved comments that need to be addressed before we can merge this.
|
Yep, I'll get on this in the coming days. Sorry for being a bit slow here :( |
|
No worries, and no rush - I've just been looking through old PRs, and this one looked like it might be waiting for me to review new changes which is why I added the note on the current state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This looks ready to merge and move on filing issues to track further feedback and work required on this proposal.
@llvm-beanz - as sponsor of this can you provide the 2nd review and shepherd this change in please?
Allow
i8andu8types, which are useful for pre-processing/post-processing data used in cooperative matrix/vector operations. Right now it's really ugly to unpack/pack viai32. This proposal enablesi8andu8as native types in the shader core.