docs(owasp): add third-party attributions to owasp-infrastructure and owasp-mcp#1388
Conversation
… owasp-mcp Issue microsoft#1325: owasp-infrastructure and owasp-mcp were the two OWASP skills shipped without Third-Party Attribution sections or the OWASP(R) trademark markers that owasp-top-10 and owasp-agentic already use. Mirror the owasp-top-10 / owasp-agentic pattern in both skills: * Add 'OWASP(R)' to the SKILL.md H1 title and to the first paragraph that names the framework version. * Add a 'Third-Party Attribution' section to each SKILL.md with the Copyright / CC BY-SA 4.0 / source URL / modifications summary / trademark disclaimer block, keyed to each skill's own source URL (www-project-top-10-infrastructure-security-risks/ and www-project-mcp-top-10/ respectively). * Append the per-reference CC BY-SA 4.0 attribution block (the same 'Content derived from works by the OWASP Foundation ...' footer owasp-top-10 and owasp-agentic references already carry) to every .md under each skill's references/ directory (22 files: 11 per skill). No content changes: only the attribution block and the trademark (R) markers. Closes microsoft#1325.
|
@WilliamBerryiii with changes coming via overall RAI related overhaul, I believe this one because stale? |
chaosdinosaur
left a comment
There was a problem hiding this comment.
Clean attribution PR — the Third-Party Attribution sections, H1 trademark markers, and all 22 per-reference CC-BY-SA-4.0 footer blocks match the established sibling pattern exactly. One minor convention nit on body paragraph trademark usage noted inline.
| This `SKILL.md` is the **entrypoint** for the OWASP Infrastructure Top 10 skill. | ||
|
|
||
| The skill encodes the **OWASP Infrastructure Security Top 10 (2024)** as structured, | ||
| The skill encodes the **OWASP® Infrastructure Security Top 10 (2024)** as structured, |
There was a problem hiding this comment.
Nit: All five sibling OWASP skills (owasp-top-10, owasp-agentic, owasp-llm, owasp-docker, owasp-cicd) use plain OWASP (no ®) in the body paragraph, reserving ® for the H1 title and the Third-Party Attribution section. This line and the equivalent in owasp-mcp/SKILL.md line 19 introduce OWASP® in the body paragraph, which breaks the convention.
| The skill encodes the **OWASP® Infrastructure Security Top 10 (2024)** as structured, | |
| The skill encodes the **OWASP Infrastructure Security Top 10 (2024)** as structured, |
Pull Request
Description
owasp-infrastructureandowasp-mcpwere the only OWASP skills in this repo that still lacked the Third-Party Attribution section and the OWASP trademark marker already used byowasp-top-10andowasp-agentic. This PR brings those two skills and their reference files up to the same attribution standard.Changes included in this PR:
OWASP®to the affected skill titles and introductory framework references.## Third-Party Attributionsection to both skillSKILL.mdfiles using the same pattern already established elsewhere in the repo.No vulnerability guidance or remediation content is changed by this PR.
Related Issue(s)
Closes #1325.
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
prompt-builderagent and addressed all feedback.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md)Other:
.ps1,.sh,.py)Sample Prompts (for AI Artifact Contributions)
User Request:
Review a change for OWASP infrastructure or MCP risks and cite the relevant framework guidance from the built-in security skills.
Execution Flow:
The skill resolver loads the updated OWASP skill metadata and references, including the new attribution/trademark text, while preserving the existing security guidance content.
Output Artifacts:
No new user-facing artifacts are created. The updated repository artifacts are the touched OWASP
SKILL.mdfiles and their reference markdown files.Success Indicators:
The affected OWASP skill files match the attribution structure already used by the sibling OWASP skills, and the reference files retain the expected footer ordering.
For detailed contribution requirements, see:
Testing
owasp-top-10andowasp-agenticpatterns..github/skills/**is already excluded by repo configuration.OWASP FoundationandOWASP®before and after to confirm the new attribution/trademark coverage matches the intended locations.Checklist
Required Checks
AI Artifact Contributions
/prompt-analyzeto review contributionprompt-builderreviewRequired Automated Checks
The following validation commands must pass before merging:
npm run lint:mdnpm run spell-checknpm run lint:frontmatternpm run validate:skillsnpm run lint:md-linksnpm run lint:psnpm run plugin:generatenpm run docs:testSecurity Considerations
Additional Notes