Enforce explicit visibility modifiers#1005
Merged
ecraig12345 merged 2 commits intomicrosoft:masterfrom Feb 7, 2026
Merged
Conversation
ecraig12345
force-pushed
the
explicit-visibility
branch
6 times, most recently
from
f40d91d to
aa45029
Compare
ecraig12345
force-pushed
the
explicit-visibility
branch
from
aa45029 to
70e1901
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce explicit visibility modifiers for classes. Yes, technically
publicis redundant, but being explicit about the intent of ALL members/methods is much better for maintainability. In theory we could enforce#for private, but that would require more changes and is riskier short-term.Also update the
e2e-testsMonorepofixture to extend from themonorepo-fixtureone, since most logic is the same. This required changing a bunch of methods to async and updating usage in the e2e tests.