Fix issue with tests failing during cleanup#882
Fix issue with tests failing during cleanup#882dobesv wants to merge 4 commits intomicrosoft:masterfrom
Conversation
|
@kenotron @ecraig12345 I opened a few PRs but no response - should I continue to try and contribute to the project or should I figure out something on my own, like make a fork to use so I can get these bugfixes applied? |
Thanks for the contributions! I asked @kenotron to take a look, since I help some with maintenance but haven't actually worked on the core logic of Lage (so I don't know the nuances of which current behaviors were intended or not, or what implications changes might have). |
The temp folder was deleted before the write stream would close, and it would cause node to exit due to an unhandled error.
0b0f612 to
c414608
Compare
|
Any update on the status of the project? I'm running into more issues and I wonder if I should expend any more effort on using or contributing to this project. @kenotron @ecraig12345 |
|
I ended up integrating the test updates into a different change, and I'm not sure the |
The temp folder was deleted before the write stream would close, and it would cause node to exit due to an unhandled error.
Fixes #864