-
Notifications
You must be signed in to change notification settings - Fork 347
Onboard AzureMigrate PlatformLandingZone Tool #1524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akshayrohilla
wants to merge
3
commits into
main
Choose a base branch
from
users/akshayrohilla/addAzureMigrateTools
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds Azure Migrate Platform Landing Zone MCP Tool support with two main commands for managing Azure Landing Zone configurations.
Changes:
- Adds
getmodificationguidancecommand for providing guidance on modifying existing Azure Landing Zone configurations - Adds
generatelandingzonecommand for generating and downloading platform landing zone configurations - Implements supporting services, models, options, and comprehensive unit tests
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.AzureMigrate/src/Services/PlatformLandingZoneService.cs | Core service for landing zone generation, parameter management, and download operations |
| tools/Azure.Mcp.Tools.AzureMigrate/src/Services/PlatformLandingZoneGuidanceService.cs | Service providing modification guidance by fetching Azure Landing Zone documentation |
| tools/Azure.Mcp.Tools.AzureMigrate/src/Commands/PlatformLandingZone/GetModificationGuidanceCommand.cs | Command implementation for getting landing zone modification guidance |
| tools/Azure.Mcp.Tools.AzureMigrate/src/Commands/PlatformLandingZone/GenerateLandingZoneCommand.cs | Command implementation for generating and downloading landing zones |
| tools/Azure.Mcp.Tools.AzureMigrate/src/Models/PlatformLandingZoneParameters.cs | Model representing landing zone configuration parameters |
| tools/Azure.Mcp.Tools.AzureMigrate/src/Models/PlatformLandingZoneGenerationPayload.cs | Payload model for landing zone generation API calls |
| tools/Azure.Mcp.Tools.AzureMigrate/src/Options/AzureMigrateOptionDefinitions.cs | Command-line option definitions for Azure Migrate tools |
| tools/Azure.Mcp.Tools.AzureMigrate/src/AzureMigrateSetup.cs | Setup class for registering services and commands |
| tools/Azure.Mcp.Tools.AzureMigrate/tests/Azure.Mcp.Tools.AzureMigrate.UnitTests/ | Comprehensive unit tests for both commands |
| servers/Azure.Mcp.Server/src/Program.cs | Integrates AzureMigrateSetup into the server |
| servers/Azure.Mcp.Server/README.md | Documentation updates for the new Azure Migrate tools |
| servers/Azure.Mcp.Server/docs/azmcp-commands.md | Command reference documentation |
| servers/Azure.Mcp.Server/docs/e2eTestPrompts.md | End-to-end test prompts for validation |
| core/Azure.Mcp.Core/src/Areas/Server/Resources/consolidated-tools.json | Tool metadata for consolidated tool registry |
tools/Azure.Mcp.Tools.AzureMigrate/src/Services/PlatformLandingZoneService.cs
Show resolved
Hide resolved
...re.Mcp.Tools.AzureMigrate/src/Commands/PlatformLandingZone/GetModificationGuidanceCommand.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.AzureMigrate/src/Options/AzureMigrateOptionDefinitions.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.AzureMigrate/src/Models/PlatformLandingZoneGenerationPayload.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.AzureMigrate/src/Commands/PlatformLandingZone/GenerateCommand.cs
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.AzureMigrate/src/Services/PlatformLandingZoneGuidanceService.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.AzureMigrate/src/Services/PlatformLandingZoneService.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.AzureMigrate/src/Services/PlatformLandingZoneGuidanceService.cs
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.AzureMigrate/src/Services/PlatformLandingZoneService.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.AzureMigrate/src/Services/PlatformLandingZoneService.cs
Outdated
Show resolved
Hide resolved
Member
|
Overall the PR is looking good.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]Onboard Azure Migrate Platform Landing Zone MCP Tool -
GitHub issue number?
1523Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline