Skip to content

Conversation

@akshayrohilla
Copy link

What does this PR do?

[Provide a clear, concise description of the changes]
Onboard Azure Migrate Platform Landing Zone MCP Tool -

  • Generate a Landing Zone
  • Modify existing Landing zone templates

GitHub issue number?

1523

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • [] For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • [] For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds Azure Migrate Platform Landing Zone MCP Tool support with two main commands for managing Azure Landing Zone configurations.

Changes:

  • Adds getmodificationguidance command for providing guidance on modifying existing Azure Landing Zone configurations
  • Adds generatelandingzone command for generating and downloading platform landing zone configurations
  • Implements supporting services, models, options, and comprehensive unit tests

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.AzureMigrate/src/Services/PlatformLandingZoneService.cs Core service for landing zone generation, parameter management, and download operations
tools/Azure.Mcp.Tools.AzureMigrate/src/Services/PlatformLandingZoneGuidanceService.cs Service providing modification guidance by fetching Azure Landing Zone documentation
tools/Azure.Mcp.Tools.AzureMigrate/src/Commands/PlatformLandingZone/GetModificationGuidanceCommand.cs Command implementation for getting landing zone modification guidance
tools/Azure.Mcp.Tools.AzureMigrate/src/Commands/PlatformLandingZone/GenerateLandingZoneCommand.cs Command implementation for generating and downloading landing zones
tools/Azure.Mcp.Tools.AzureMigrate/src/Models/PlatformLandingZoneParameters.cs Model representing landing zone configuration parameters
tools/Azure.Mcp.Tools.AzureMigrate/src/Models/PlatformLandingZoneGenerationPayload.cs Payload model for landing zone generation API calls
tools/Azure.Mcp.Tools.AzureMigrate/src/Options/AzureMigrateOptionDefinitions.cs Command-line option definitions for Azure Migrate tools
tools/Azure.Mcp.Tools.AzureMigrate/src/AzureMigrateSetup.cs Setup class for registering services and commands
tools/Azure.Mcp.Tools.AzureMigrate/tests/Azure.Mcp.Tools.AzureMigrate.UnitTests/ Comprehensive unit tests for both commands
servers/Azure.Mcp.Server/src/Program.cs Integrates AzureMigrateSetup into the server
servers/Azure.Mcp.Server/README.md Documentation updates for the new Azure Migrate tools
servers/Azure.Mcp.Server/docs/azmcp-commands.md Command reference documentation
servers/Azure.Mcp.Server/docs/e2eTestPrompts.md End-to-end test prompts for validation
core/Azure.Mcp.Core/src/Areas/Server/Resources/consolidated-tools.json Tool metadata for consolidated tool registry

@KarishmaGhiya
Copy link
Member

KarishmaGhiya commented Jan 20, 2026

Overall the PR is looking good.

  • What's the tool description evaluator score?
  • Were you able to run live tests for this? If the live tests work, then we need to record those tests, so that the recorded tests can run in the pipeline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

3 participants