fix for uncomparable errors in errors pkg #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikohobart
force-pushed
the
user/nhobart/remove-unnecessary-comparison-causing-panic
branch
from
816ae7b to
8049913
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
raghavendra-nataraj
approved these changes
Nov 15, 2024
yeonghunki
approved these changes
Nov 15, 2024
aeweston-msft
approved these changes
Nov 15, 2024
apluchik
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents uncomparable errors from creating panics when checking for moc code.
Added tests to ensure uncomparable errors are handled correctly.
Note: this doesn't actually change the current logic, we still have the same outcome, we just don't use comparable types as part of that anymore.
Work Item: https://msazure.visualstudio.com/One/_workitems/edit/30244234