[moc] Add AvailabilitySet Operation for Add/Remove VM #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
madhanrm
previously approved these changes
Jul 24, 2025
…inanliu/AvSetUpdateIdem merging to get latest from master
madhanrm
previously approved these changes
Aug 5, 2025
msftpgayam
reviewed
Aug 6, 2025
rpc/cloudagent/compute/availabilityset/moc_cloudagent_availabilityset.proto
Outdated
Show resolved
Hide resolved
rpc/nodeagent/compute/availabilityset/moc_nodeagent_availabilityset.proto
Outdated
Show resolved
Hide resolved
ruinan-liu
commented
Aug 7, 2025
Contributor
Author
ruinan-liu
left a comment
ruinan-liu
left a comment
There was a problem hiding this comment.
Replied to comments
msftpgayam
reviewed
Aug 8, 2025
go.mod
Outdated
| github.com/golang/protobuf v1.5.4 | ||
| github.com/hectane/go-acl v0.0.0-20230122075934-ca0b05cb1adb | ||
| github.com/jmespath/go-jmespath v0.4.0 | ||
| github.com/microsoft/moc-pkg v0.13.3 |
Contributor
There was a problem hiding this comment.
Any idea why is this being added? Does moc depend on moc-pkg?
Contributor
Author
There was a problem hiding this comment.
I think it is because this file is using it
https://github.com/microsoft/moc/blob/main/pkg/fs/fs_windows.go
Contributor
There was a problem hiding this comment.
But you're not making any changes to this file, right? Any idea why your PR is bringing in the dependency on moc-pkg?
ruinan-liu
commented
Aug 8, 2025
Contributor
Author
ruinan-liu
left a comment
ruinan-liu
left a comment
There was a problem hiding this comment.
Replied to comments
Contributor
Author
|
/azp |
Supported commands
See additional documentation. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
msftpgayam
approved these changes
Aug 8, 2025
chengzy1994
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added AvailabilitySetOperation Struct and introduced 2 operation types Add_VM, Remove_VM